fix(UnusedVariable): skip synthetic fields with no explicit source position - #6018
Open
waterWang wants to merge 1 commit into
Open
fix(UnusedVariable): skip synthetic fields with no explicit source position#6018waterWang wants to merge 1 commit into
waterWang wants to merge 1 commit into
Conversation
…sition When Lombok generates a field (e.g., the 'log' field from @slf4j), the AST node has a synthetic source position (Position.NOPOS). The UnusedVariable checker would flag these fields as unused and attempt to build a fix, but replaceIncludingComments throws a SourcePositionException because the position doesn't map to any actual source code. Fix: add a hasExplicitSource check in handleVariable to skip variables that don't have a valid source position. This is the same pattern already used in buildUnusedParameterFixes (line 610) to handle enum constructors with bogus positions. Fixes google#5964
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When Lombok generates a field (e.g., the
logfield from@Slf4j), the AST node has a synthetic source position (Position.NOPOS). TheUnusedVariablechecker flags these fields as unused and attempts to build a fix, butreplaceIncludingCommentsthrows aSourcePositionExceptionbecause the position doesn't map to any actual source code.Stack trace:
SourcePositionException: invalid source positionatUnusedVariable.buildUnusedVarFixes.Fix
Add a
hasExplicitSourcecheck inhandleVariableto skip variables that don't have a valid source position. This is the same pattern already used inbuildUnusedParameterFixesto handle enum constructors with bogus positions.hasExplicitSourcereturnsfalsewhen the start or end position isPosition.NOPOSor when they are equal, which is exactly the case for Lombok-generated nodes.References
Fixes #5964