Refactor isReassigned in PatternMatchingInstanceof to use the local field trick - #6016
Merged
Conversation
…al field trick Use `TreeScanner<Void, Void>` with a local `boolean` field to track reassignment instead of `TreeScanner<Boolean, Void>` with `reduce()`. This allows short-circuiting AST traversal once reassignment is found and removes unnecessary boxing/unboxing. PiperOrigin-RevId: 962436051
copybara-service
Bot
force-pushed
the
test_962411901
branch
from
August 10, 2026 23:39
8f1da5d to
41c1623
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactor
isReassignedinPatternMatchingInstanceofto use the local field trickUse
TreeScanner<Void, Void>with a localbooleanfield to track reassignment instead ofTreeScanner<Boolean, Void>withreduce(). This allows short-circuiting AST traversal once reassignment is found and removes unnecessary boxing/unboxing.