Skip to content

Avoid warning multiple times for "sun.misc.Unsafe.class." #6014

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
copybara-service wants to merge 1 commit into
base: master
Choose a base branch
from
+11 −0
Open

Avoid warning multiple times for "sun.misc.Unsafe.class." #6014

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions core/src/main/java/com/google/errorprone/bugpatterns/SunApi.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,9 @@ public Description matchIdentifier(IdentifierTree tree, VisitorState state) {

@Override
public Description matchMemberSelect(MemberSelectTree tree, VisitorState state) {
if (tree.getIdentifier().equals(state.getNames()._class)) {
return NO_MATCH;
}
return match(tree, state);
}

Expand Down
8 changes: 8 additions & 0 deletions core/src/test/java/com/google/errorprone/bugpatterns/SunApiTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,10 @@ public void positive() {
class Test {
// BUG: Diagnostic contains: sun.misc.Unsafe
sun.misc.Unsafe u;

// BUG: Diagnostic contains: sun.misc.Unsafe
Object u2 = sun.misc.Unsafe
.class;
}
""")
.doTest();
Expand All @@ -50,6 +54,10 @@ public void positiveSource8() {
class Test {
// BUG: Diagnostic contains: sun.misc.Unsafe
sun.misc.Unsafe u;

// BUG: Diagnostic contains: sun.misc.Unsafe
Object u2 = sun.misc.Unsafe
.class;
}
""")
.setArgs("-source", "8", "-target", "8")
Expand Down
Loading