Skip to content

util/semver: fix a panic with nuget parsing #400

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
calebbrown merged 2 commits into from
Sep 28, 2026
+6 −1
Merged

util/semver: fix a panic with nuget parsing #400

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9fd73b1
util/semver: fix a panic with nuget parsing
calebbrown Sep 25, 2026
de7d49d
Merge branch 'main' into fix_nuget_panic
calebbrown Sep 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions util/semver/nuget_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,6 +74,8 @@ var nugetVersionParseTests = []versionParseTest{
v("1.*.*", "version has multiple wildcards in `1.*.*`", ""),
v("1.0.0*-alpha", "missing asterisk at end of prerelease in `1.0.0*-alpha`", ""),
v("1.0.0-a*a*", "invalid text in version string in `1.0.0-a*a*`", ""),
v("1*.", "invalid text in version string in `1*.`", ""),
v("1*-", "empty pre-release metadata in `1*-`", ""),
}

func TestNuGetVersionParse(t *testing.T) {
Expand Down
5 changes: 4 additions & 1 deletion util/semver/version.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -526,9 +526,12 @@ func (p *versionParser) version() (*Version, error) {
// NuGet allows for the metadata part to start and end with an
// asterisk.
r = p.lex.next()
if r != eof {
if r == '-' {
p.isPrerelease = true
r = p.metadata(&p.pre, false, "pre-release")
if len(p.pre) == 0 {
return nil, p.lex.err
}
l := p.pre[len(p.pre)-1]
if l[len(l)-1] != '*' {
p.lex.setErr("missing asterisk at end of prerelease")
Expand Down
Loading