Split out slide for IntoIterator on references - #3281
Merged
Merged
Conversation
fw-immunant
requested changes
Sep 21, 2026
fw-immunant
left a comment
fw-immunant
left a comment
Collaborator
There was a problem hiding this comment.
A few tweaks commented inline, but this is a good change; the flow of teaching this can be annoying with the current slides.
- Update speaker note on IntoIterator slide. - Update GridRefIter to return &u32 to be more idiomatic. - Update linked playground to match code in the slide.
fw-immunant
approved these changes
Sep 28, 2026
fw-immunant
left a comment
fw-immunant
left a comment
Collaborator
There was a problem hiding this comment.
Thanks for updates, LGTM.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently the slide on
IntoIteratordemonstrates implementing it directly on a type, and then links to a playground in order to demonstrate implementingIntoIteratoron references. This PR pulls that playground out into its own slide and adds some speaker notes to guide the discussion and call out how this pattern is used in the standard library.This is how I've been teaching this section for a while, and I think it goes pretty smoothly, so it's probably worth making into an actual slide.