Skip to content

[Better Tests] Adds the GCE metadata fake - #5480

Merged
IvanBM18 merged 7 commits into
better-tests/01a-metadata-emulator-configsfrom
better-tests/02-metadata-emulator-core
Oct 6, 2026
Merged

IvanBM18 merged 7 commits into
better-tests/01a-metadata-emulator-configsfrom
better-tests/02-metadata-emulator-core

Conversation

@IvanBM18

@IvanBM18 IvanBM18 commented Sep 22, 2026 •

Copy link
Copy Markdown
Collaborator

Bug: b/555370359

Creates a GCE metadata emulator for our future integration test suite, built on Testcontainers and WireMock. It lets tests resolve credentials and read instance and project metadata without a real GCE host or a local gcloud login, and lets them distinguish a trusted from an untrusted environment.

google-auth and our vendored oauth2client evaluate the GCE_METADATA_* environment variables once, at import time, and bake the resulting URL in. Importing this module therefore claims two loopback addresses up front; the addresses never move, only what listens on them does. A test picks its in-process identity by picking which fixture answers on the default address:

with gce_metadata_emulator.trusted_as_default() as tworker:
  ...
with gce_metadata_emulator.untrusted_as_default() as uworker:
  ...
with gce_metadata_emulator.trusted_untrusted_pair() as (tworker, uworker):
  ...  # uworker sits on the secondary address

Nothing is patched to make that work. An emulator on the secondary address is reachable through the client its context manager yields, or by handing its env to a child process:

subprocess.run(argv, env={**os.environ, **uworker.env})

This emulator was based off the pre-existing local emulator go wrap + what is detailed at the GCP metadata server docs

Changes

  • Add gce_metadata_emulator.py, a WireMock Testcontainer fake GCE metadata server. Supports:
    • Serving fake service account credentials, so a test can tell a trusted from an untrusted environment.
    • Serving project- and instance-scoped metadata values, including attribute shadowing, seeded from the JSON configs added in [Better Tests] Add GCE metadata emulator worker/uworker configs #5485.
    • Rejecting requests that omit Metadata-Flavor: Google, the way the real server does.
    • Failing loudly when two emulators want the same address.

The tests covering all of this land in #5486, next in the stack.

📚 Stacked PRs

Step PR Title Base Branch
0 #5475 [Better Tests] Adds new test dependencies master
1 #5479 [Better Tests] Support GCE_METADATA_HOST with port in compute_metadata better-test/dependencies
2 #5485 [Better Tests] Add GCE metadata emulator worker fixtures better-tests/01-compute-metadata-host
3 #5480 [Better Tests] Add the WireMock GCE metadata emulator (👉 This PR) better-tests/01a-metadata-emulator-configs
4 #5486 [Better Tests] Bootstrap and cover the GCE metadata emulator better-tests/02-metadata-emulator-core
5 #5481 [Better Tests] Add fault injection and runtime overrides to metadata emulator better-tests/02a-metadata-emulator-tests

Comment thread src/clusterfuzz/_internal/tests/core/google_cloud_utils/metadata_emulator_test.py Outdated
Comment thread src/clusterfuzz/_internal/tests/core/google_cloud_utils/metadata_emulator_test.py Outdated
Comment thread src/clusterfuzz/_internal/tests/core/google_cloud_utils/metadata_emulator_test.py Outdated
Comment thread src/clusterfuzz/_internal/tests/core/google_cloud_utils/metadata_emulator_test.py Outdated
Comment thread src/clusterfuzz/_internal/tests/test_libs/metadata_emulator.py Outdated
Comment thread src/clusterfuzz/_internal/tests/test_libs/gce_metadata_emulator.py Outdated
Comment thread test_suites/fixtures/gce_metadata_server.py
Comment thread src/clusterfuzz/_internal/tests/test_libs/gce_metadata_emulator.py Outdated
@IvanBM18
IvanBM18 force-pushed the better-tests/02-metadata-emulator-core branch 3 times, most recently from e9e1eda to 3be942a Compare September 23, 2026 18:12
@IvanBM18 IvanBM18 changed the title [Better Tests] Add WireMock GCE metadata emulator and worker fixtures [Better Tests] Add the WireMock GCE metadata emulator Sep 23, 2026
@IvanBM18
IvanBM18 changed the base branch from better-tests/01-compute-metadata-host to better-tests/01a-metadata-emulator-configs September 23, 2026 18:13
@IvanBM18
IvanBM18 added this pull request to stack #5497 September 25, 2026 01:44
@IvanBM18
IvanBM18 marked this pull request as ready for review September 25, 2026 01:45
@IvanBM18
IvanBM18 requested a review from a team as a code owner September 25, 2026 01:45
@IvanBM18
IvanBM18 requested a review from dylanjew September 25, 2026 02:12
@IvanBM18
IvanBM18 force-pushed the better-tests/02-metadata-emulator-core branch from 3be942a to ddad6a6 Compare September 28, 2026 16:54
values from a JSON fixture, so tests can resolve credentials and read metadata
without a real GCE host or login.

Start order matters: google-auth and our vendored oauth2client read the

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a bit hard to read. Could you focus this documentation on what this fake does and how it should be used?

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, done!

Comment thread test_suites/fixtures/gce_metadata_server.py
from wiremock.testing.testcontainer import wiremock_container


def _find_free_port() -> int:

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i've also seen test servers hardcode ports and throw an error if it's already in use. There's also a bunch of handling for if the port is in use in this class. Do we need to do both? would it be simpler to also hardcode here?

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mmm no we don't need both port finding + port error handling, I added them so we could have better error msgs, but I guess its overcomplicating this code. SO in favor of simplicity I'll also add hardcoded ports as well, maybe we can come back to this idea later if we want to speed up testing times by launching multiple concurrent tests.

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, this is simpler! is there an error message thrown if the port is in use?

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, when standing up the server it will throw an exception, theres a test for that in our test pr

@IvanBM18
IvanBM18 force-pushed the better-tests/02-metadata-emulator-core branch from d3b87dc to 07aa8f1 Compare September 30, 2026 18:00
@IvanBM18
IvanBM18 force-pushed the better-tests/02-metadata-emulator-core branch from 93a1565 to fd06489 Compare September 30, 2026 19:23

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needed so:
Imports like from test_suites.fixtures import ...
Resolve cleanly, we can later remove this once we figure out the butler.py command for the new test suite

Comment thread test_suites/__init__.py

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dito ^
Needed so:
Imports like from test_suites.fixtures import ...
Resolve cleanly, we can later remove this once we figure out the butler.py command for the new test suite

@IvanBM18 IvanBM18 changed the title [Better Tests] Add the WireMock GCE metadata emulator [Better Tests] Adds the GCE metadata fake Sep 30, 2026
@IvanBM18
IvanBM18 requested a review from dylanjew September 30, 2026 20:48

@dylanjew dylanjew left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@IvanBM18 IvanBM18 added ready for GOSST review Pull requests ready for GOSST team review Tests PRs focused merely on tests suite changes labels Sep 30, 2026
@IvanBM18
IvanBM18 requested a review from decoNR September 30, 2026 21:49
Comment thread test_suites/fixtures/gce_metadata_server.py
@IvanBM18
IvanBM18 force-pushed the better-tests/02-metadata-emulator-core branch from 38f3f2b to 7501972 Compare October 2, 2026 17:12
Runs a WireMock testcontainer that answers as a GCE metadata server, so
integration tests can resolve credentials and read metadata without a
real GCE host or a gcloud login.

Importing the module claims two loopback addresses. The Google auth
libraries resolve the metadata address once, at import time, so a test
picks its in-process identity by picking which fixture listens on the
default address:

  with gce_metadata_emulator.trusted_as_default() as tworker:
    ...
  with gce_metadata_emulator.trusted_untrusted_pair() as (t, u):
    ...

Nothing is patched to make that work: the addresses never move, only
what listens on them does. The runner-side bootstrap() call and the
tests covering all of this land in the next PR.
…new test suite

Adds __init__.py files so it imports as test_suites.fixtures, resolves the
seed configs relative to the module instead of the working directory, and
updates the docs to the new module and config locations.
@IvanBM18
IvanBM18 force-pushed the better-tests/02-metadata-emulator-core branch from 7501972 to d261f38 Compare October 6, 2026 22:19
@IvanBM18
IvanBM18 merged commit 55cb8da into master Oct 6, 2026
14 checks passed
@IvanBM18
IvanBM18 deleted the better-tests/02-metadata-emulator-core branch October 6, 2026 22:23
IvanBM18 added a commit that referenced this pull request Oct 6, 2026
Bug: b/555370359

We can redirect `google-auth` metadata requests to a local emulator via
the `GCE_METADATA_HOST` environment variable, but ClusterFuzz's own
`compute_metadata.py` previously hardcoded `metadata.google.internal`
and port `80`. Reading `GCE_METADATA_HOST` and parsing optional ports
allows local integration tests to run a metadata emulator on an
ephemeral unprivileged port without root privileges or `/etc/hosts`
changes.


## Changes
- Update `_METADATA_SERVER` in `compute_metadata.py` to read
`GCE_METADATA_HOST` from the environment, falling back to
`metadata.google.internal`.
- Add unit tests in covering `_metadata_host_port()`, `is_gce()` on
non-default ports, and `GCE_METADATA_HOST` overrides.


### 📚 Stacked PRs
| Step | PR | Title | Base Branch |
| :---: | :--- | :--- | :--- |
| 0 | #5475 | `[Better Tests] Adds new test dependencies` | `master` |
| **1** | **#5479** | **`[Better Tests] Support GCE_METADATA_HOST with
port in compute_metadata`** *(👉 This PR)* | `better-test/dependencies` |
| 2 | #5485 | `[Better Tests] Add GCE metadata emulator worker fixtures`
| `better-tests/01-compute-metadata-host` |
| 3 | #5480 | `[Better Tests] Add the WireMock GCE metadata emulator` |
`better-tests/01a-metadata-emulator-configs` |
| 4 | #5486 | `[Better Tests] Bootstrap and cover the GCE metadata
emulator` | `better-tests/02-metadata-emulator-core` |
| 5 | #5481 | `[Better Tests] Add fault injection and runtime overrides
to metadata emulator` | `better-tests/02a-metadata-emulator-tests` |
IvanBM18 added a commit that referenced this pull request Oct 6, 2026
Bug: b/555370359


Split out of #5480, which had grown to 821 lines across the fixtures,
the emulator that serves them, and the tests that exercise it.

This PR is the data half: the JSON configs the GCE metadata emulator
seeds itself from. Each config describes one worker identity, so a test
can pick whether it runs trusted or untrusted by picking which fixture
answers on the default address.

The shape of `metadata` mirrors the real metadata server's hierarchy, so
a config can be retrieved by reading a live instance:

```
curl -H 'Metadata-Flavor: Google' \
  'http://metadata.google.internal/computeMetadata/v1/?recursive=true' | jq
```

## Changes

- Add `local/emulators/configs/tworker.json`: the trusted worker
identity, with its service account email, scopes, a fake access token,
and the project and instance metadata a tworker reads.
- Add `local/emulators/configs/uworker.json`: the untrusted counterpart,
so both can run side by side and be shown to stay distinct.
- Add `local/emulators/configs/template.json`: an annotated reference
for writing a new config. It is documentation rather than a loadable
fixture, so it keeps its `//` comments; nothing parses it.
`tworker.json` and `uworker.json` are plain JSON and are the only two
loaded.

Nothing reads these yet. The emulator that serves them is #5480, next in
the stack.


### 📚 Stacked PRs
| Step | PR | Title | Base Branch |
| :---: | :--- | :--- | :--- |
| 0 | #5475 | `[Better Tests] Adds new test dependencies` | `master` |
| 1 | #5479 | `[Better Tests] Support GCE_METADATA_HOST with port in
compute_metadata` | `better-test/dependencies` |
| **2** | **#5485** | **`[Better Tests] Add GCE metadata emulator worker
fixtures`** *(👉 This PR)* | `better-tests/01-compute-metadata-host` |
| 3 | #5480 | `[Better Tests] Add the WireMock GCE metadata emulator` |
`better-tests/01a-metadata-emulator-configs` |
| 4 | #5486 | `[Better Tests] Bootstrap and cover the GCE metadata
emulator` | `better-tests/02-metadata-emulator-core` |
| 5 | #5481 | `[Better Tests] Add fault injection and runtime overrides
to metadata emulator` | `better-tests/02a-metadata-emulator-tests` |
IvanBM18 added a commit that referenced this pull request Oct 6, 2026
Bug: b/555370359

Split out of #5480. This PR wires the GCE metadata emulator added in
#5480 into the test runner, and covers it.

## Note
- This is the first of many integration test modules, for this purpose,
it uses `pytest` library instead of `unittest`, this requires different
syntax for asserting, but files & methods naming is basically the same.
- This is a experimental integration test module, still a standalone, we
require to wire a couple of things with a butler command to allow easy
execution of this kind of tests like we do with unit test, this will be
done in a subsequent bug: b/540876792
- Documentation will be created in b/555424439 once we have our first
set of integration test suites & the butler command is ready to run them
- I aim to create documentation & guidelines to be created based off
this first tests and overall the discussion we have in the PRs for them,
so feel free to push back on even the smallest details, nothing is set
in stone!


## Changes

- Adds `gce_metadata_emulator_test.py`, skipped right now because its
experimental, just in case this ends in the CI process before we
intended to.

## Tests

- `GceMetadataEmulatorTest` an integration test for how some common
workflows behave using the new emulator, runs a trusted and an untrusted
emulator side by side and verifies:

- `GceMetadataEmulatorUntrustedDefaultTest` puts a metadata server that
returns uworker on the default address and verifies that all resolve to
the untrusted identity.

To run it:

```
PYTHONPATH=src:src/third_party pytest test_suites/fixtures/gce_metadata_server_test.py
```

We need to later include them in `butler.py` so that we can:
- Run them smoothly
- Don't require to do the imports manually

But theres already a bug for that, and the purpose of this is not
creating the butler setup but to create an emulator for other tests.

### 📚 Stacked PRs
| Step | PR | Title | Base Branch |
| :---: | :--- | :--- | :--- |
| 0 | #5475 | `[Better Tests] Adds new test dependencies` | `master` |
| 1 | #5479 | `[Better Tests] Support GCE_METADATA_HOST with port in
compute_metadata` | `better-test/dependencies` |
| 2 | #5485 | `[Better Tests] Add GCE metadata emulator worker fixtures`
| `better-tests/01-compute-metadata-host` |
| 3 | #5480 | `[Better Tests] Add the WireMock GCE metadata emulator` |
`better-tests/01a-metadata-emulator-configs` |
| **4** | **#5486** | **`[Better Tests] Bootstrap and cover the GCE
metadata emulator`** *(👉 This PR)* |
`better-tests/02-metadata-emulator-core` |
| 5 | #5481 | `[Better Tests] Add fault injection and runtime overrides
to metadata emulator` | `better-tests/02a-metadata-emulator-tests` |
IvanBM18 added a commit that referenced this pull request Oct 6, 2026
…data fake values (#5481)

Bug: b/555370359

Following the parent PR, this one introduces changes for our emulator so
that we can force it to fail either constantly, or on demand, this opens
a ton of possibilities for integration tests, this is technically also a
new feature, but to simplify reviews i moved this one to a separate PR.

With this changes it now simulates transient GCE metadata server
failures (such as HTTP 500s or latency spikes) and mutate
instance/project attributes dynamically during a test without restarting
the WireMock container. Using WireMock stateful scenarios allows
injecting faults that automatically expire after N requests so retry
decorators (such as `@retry.wrap` on `compute_metadata.get()`) can be
tested deterministically.

## Changes

- Adds an interface(for composition instead of inheritance) for so that
we can inject fault mapping to any API that uses wiremock as its base
starting with the metadata_emulator.
- Track runtime instance attribute overrides via
`_runtime_instance_attributes` so `set_project_attribute()` does not
overwrite attributes shadowed at runtime, and reset them in
`clear_faults()`.
- Adds tests cases for this.

### 📚 Stacked PRs
| Step | PR | Title | Base Branch |
| :---: | :--- | :--- | :--- |
| 0 | #5475 | `[Better Tests] Adds new test dependencies` | `master` |
| 1 | #5479 | `[Better Tests] Support GCE_METADATA_HOST with port in
compute_metadata` | `better-test/dependencies` |
| 2 | #5485 | `[Better Tests] Add GCE metadata emulator worker fixtures`
| `better-tests/01-compute-metadata-host` |
| 3 | #5480 | `[Better Tests] Add the WireMock GCE metadata emulator` |
`better-tests/01a-metadata-emulator-configs` |
| 4 | #5486 | `[Better Tests] Bootstrap and cover the GCE metadata
emulator` | `better-tests/02-metadata-emulator-core` |
| **5** | **#5481** | **`[Better Tests] Add fault injection and runtime
overrides to metadata emulator`** *(👉 This PR)* |
`better-tests/02a-metadata-emulator-tests` |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready for GOSST review Pull requests ready for GOSST team review Tests PRs focused merely on tests suite changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants