Respect exclude patterns in reproducibility test - #5471
Merged
Merged
Conversation
Filter out crashes that match any exclude pattern during the reproducibility test. This fixes the issue that a crash would be treated as alleged reliably reproducible even if all reproducibility runs matched the exclude pattern. Before this commit, the exclude patterns (ignore_stacktrace) were checked in a few scenarios (check_for_initial_crash, variant_task, reproduce_with_retries, check_for_bad_build), but not in test_reproduce_reliability. b/551164285
emaxx-google
marked this pull request as ready for review
September 15, 2026 20:30
Contributor
|
/gcbrun |
Contributor
|
/gcbrun |
Contributor
|
/gcbrun |
PauloVLB
reviewed
Sep 24, 2026
PauloVLB
approved these changes
Sep 24, 2026
Collaborator
|
/gcbrun |
Contributor
Author
|
Thanks! Could you please merge it into the tree if this looks good? |
Collaborator
|
/gcbrun |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Filter out crashes that match any exclude pattern during the reproducibility test. This fixes the issue that a crash would be treated as allegedly reliably reproducible even if all reproducibility runs matched the exclude pattern.
Before this commit, the exclude patterns (ignore_stacktrace) were checked in a few scenarios (check_for_initial_crash, variant_task, reproduce_with_retries, check_for_bad_build), but not in test_reproduce_reliability.
b/551164285