Repository navigation
Add pip req arm64 - #5468
Merged
JuanMBriones merged 0 commit intoSep 25, 2026
Merged
Add pip req arm64#5468JuanMBriones merged 0 commit into
JuanMBriones merged 0 commit into
Conversation
JuanMBriones
added this pull request to stack #5469
September 11, 2026 19:47
JuanMBriones
force-pushed
the
add_pip_req_arm64
branch
from
September 15, 2026 05:36
77e44bd to
dd68bf6
Compare
g-ortuno
requested changes
Sep 15, 2026
JuanMBriones
commented
Sep 15, 2026
JuanMBriones
force-pushed
the
add_pip_req_arm64
branch
from
September 18, 2026 18:38
dd68bf6 to
516d050
Compare
Collaborator
|
I think you pushed your radamsa changes to this branch 😅 |
JuanMBriones
force-pushed
the
add_pip_req_arm64
branch
from
September 21, 2026 23:22
516d050 to
0aa185a
Compare
JuanMBriones
removed this pull request from stack #5469
September 21, 2026 23:52
JuanMBriones
added this pull request to stack #5478
September 21, 2026 23:54
JuanMBriones
force-pushed
the
add_pip_req_arm64
branch
from
September 21, 2026 23:54
0aa185a to
d8983dd
Compare
JuanMBriones
force-pushed
the
add_pip_req_arm64
branch
2 times, most recently
from
September 22, 2026 01:25
6363a0e to
89cac14
Compare
JuanMBriones
force-pushed
the
add_pip_req_arm64
branch
from
September 22, 2026 01:41
89cac14 to
1e64d39
Compare
g-ortuno
approved these changes
Sep 22, 2026
g-ortuno
added
the
ready for GOSST review
JuanMBriones
force-pushed
the
add_pip_req_arm64
branch
from
September 22, 2026 21:52
1e64d39 to
bdb58f4
Compare
JuanMBriones
force-pushed
the
add_pip_req_arm64
branch
from
September 23, 2026 05:02
bdb58f4 to
4551485
Compare
JuanMBriones
force-pushed
the
add_pip_req_arm64
branch
from
September 23, 2026 05:18
4551485 to
ddd709a
Compare
JuanMBriones
removed this pull request from stack #5478
September 23, 2026 06:52
JuanMBriones
added this pull request to stack #5484
September 23, 2026 06:53
JuanMBriones
force-pushed
the
add_pip_req_arm64
branch
from
September 23, 2026 15:37
ddd709a to
96e53e4
Compare
JuanMBriones
force-pushed
the
add_pip_req_arm64
branch
from
September 23, 2026 17:50
96e53e4 to
9c54b09
Compare
Collaborator
|
@PauloVLB PTAL! |
PauloVLB
approved these changes
Sep 24, 2026
JuanMBriones
force-pushed
the
add_pip_req_arm64
branch
from
September 24, 2026 18:44
9c54b09 to
2cf913b
Compare
JuanMBriones
force-pushed
the
add_pip_req_arm64
branch
from
September 25, 2026 20:50
2cf913b to
38eb3ca
Compare
ViniciustCosta
pushed a commit
that referenced
this pull request
Sep 29, 2026
Same changes as #5468. Faced a bug while using gh stack github/gh-stack#385. The past PR is claimed to be "merged" but it isn't. ----- When packaging bot deployment bundles on a Linux host via butler package, _install_pip() installs all packages from Pipfile.lock (including transitive dependencies with Linux x86_64 ELF shared objects) into src/third_party. _install_platform_pip() then downloads pre-compiled binary wheels for each package listed in src/platform_requirements.txt to replace the Linux binaries with target platform native binaries. Previously, markupsafe and pynacl were transitive dependencies containing compiled C/CFFI extensions that were missing from src/platform_requirements.txt: markupsafe==3.0.3 (transitive dependency of Jinja2==3.1.4 / Flask): contains the compiled C extension markupsafe/_speedups.cpython-*.so. Without it in platform_requirements.txt, the Linux ELF .so remained in the macOS ARM64 bundle. pynacl==1.6.0 (transitive dependency of pygithub==1.55): contains the compiled libsodium CFFI native binary nacl/_sodium.abi3.so. Without it in platform_requirements.txt, importing github / nacl on macOS ARM64 fails with ImportError: dlopen(.../nacl/_sodium.abi3.so): not a mach-o file. Adding both packages ensures butler package -p macos_arm64 downloads the native macOS ARM64/universal2 wheels (markupsafe-3.0.3-cp311-cp311-macosx_11_0_arm64.whl and pynacl-1.6.0-cp38-abi3-macosx_10_10_universal2.whl) into src/third_party. Bug: 555853673 Signed-off-by: Manuel Briones <manuelbriones@google.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When packaging bot deployment bundles on a Linux host via
butler package,_install_pip()installs all packages fromPipfile.lock(includingtransitive dependencies with Linux x86_64 ELF shared objects) into
src/third_party._install_platform_pip()then downloads pre-compiledbinary wheels for each package listed in
src/platform_requirements.txtto replace the Linux binaries with target platform native binaries.
Previously,
markupsafeandpynaclwere transitive dependencies containingcompiled C/CFFI extensions that were missing from
src/platform_requirements.txt:markupsafe==3.0.3(transitive dependency ofJinja2==3.1.4/Flask):contains the compiled C extension
markupsafe/_speedups.cpython-*.so.Without it in
platform_requirements.txt, the Linux ELF.soremained inthe macOS ARM64 bundle.
pynacl==1.6.0(transitive dependency ofpygithub==1.55): contains thecompiled libsodium CFFI native binary
nacl/_sodium.abi3.so. Without it inplatform_requirements.txt, importinggithub/naclon macOS ARM64 failswith
ImportError: dlopen(.../nacl/_sodium.abi3.so): not a mach-o file.Adding both packages ensures
butler package -p macos_arm64downloads thenative macOS ARM64/universal2 wheels (
markupsafe-3.0.3-cp311-cp311-macosx_11_0_arm64.whland
pynacl-1.6.0-cp38-abi3-macosx_10_10_universal2.whl) intosrc/third_party.Bug: 555853673