Add output_dir arg to download_fuzzer_config script - #5430
Merged
Merged
Conversation
dylanjew
force-pushed
the
dylanj/download-config
branch
from
October 5, 2026 18:33
9b77276 to
50cc8b3
Compare
dylanjew
changed the title
This allows the config to directly be placed into the repo with our fuzzers.
dylanjew
force-pushed
the
dylanj/download-config
branch
from
October 5, 2026 18:37
50cc8b3 to
d4e8865
Compare
dylanjew
marked this pull request as ready for review
October 5, 2026 18:39
aakallam
changed the title
aakallam
approved these changes
Oct 5, 2026
aakallam
left a comment
aakallam
left a comment
Collaborator
There was a problem hiding this comment.
Approving because this script is only used by Chrome Fuzzing
Collaborator
|
@dylanjew no need to do it for this PR, but we should update |
Collaborator
Author
Good point, will do! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows us to directly put the config into our fuzzers repo for version control.
Also adds tests for the arg.
please approve: this doesn't need GOSST approval
I tested this locally.