Repository navigation
Fix single-instance start after stop in multi-instance groups - #3514
Queued
SuperStrongDinosaur wants to merge 2 commits into
Queued
SuperStrongDinosaur wants to merge 2 commits into
SuperStrongDinosaur wants to merge 2 commits into
Conversation
SuperStrongDinosaur
force-pushed
the
fix_single_instance_start
branch
from
November 4, 2026 16:00
b019e98 to
adaff21
Compare
SuperStrongDinosaur
marked this pull request as ready for review
November 5, 2026 16:01
Databean
reviewed
Nov 6, 2026
ser-io
requested changes
Nov 9, 2026
ser-io
requested changes
Nov 9, 2026
Databean
approved these changes
Nov 9, 2026
SuperStrongDinosaur
force-pushed
the
fix_single_instance_start
branch
from
November 10, 2026 10:02
63ebfaa to
c1ea742
Compare
ser-io
approved these changes
Nov 10, 2026
SuperStrongDinosaur
force-pushed
the
fix_single_instance_start
branch
from
November 11, 2026 09:28
c1ea742 to
6313b33
Compare
SuperStrongDinosaur
enabled auto-merge
November 11, 2026 10:29
SuperStrongDinosaur
added
kokoro:run
GoogleCuttlefishTesterBot
removed
kokoro:run
Allow `--report_anonymous_usage_stats` and `INSTANCE_STATE_BOOT_FAILED` in `CanBypassToSingleInstance` for backwards compatibility and boot-failure retries. Update `LaunchSingleInstance` to run `run_cvd` with the instance directory as its working directory (matching `cvd_internal_start` so `secure_env` stores TPM/KeyMint state in the instance directory rather than failing in a read-only daemon CWD), and parameterize `LaunchDevice` with `instances` so `LaunchSingleInstance` pre-registers only the target instance with the operator and stops only the target instance (with a 5s launcher timeout) on boot failure. Also exclude shared `assembly_dir()` from `stop_cvd`'s fallback stop when stopping a subset of instances so running sibling instances are not disrupted. Bug: 581680503 Test: bazel test //cuttlefish/host/commands/cvd/... //cuttlefish/host/commands/stop/... Assisted-by: Jetski:Gemini
Remove the deprecated `--report_anonymous_usage_stats` flag from `Instance.Start`, `Group.Start`, and `StartOptions` in Host Orchestrator. Rename `TestStopStart` to `TestGroupStopStart` without changing its behavior, and add `TestSingleInstanceStopStart` to cover stopping and starting a single secondary instance within a multi-instance group. Bug: 581680503 Test: go test ./... in frontend/src/host_orchestrator Test: bazel build //orchestration/stop_start_test:stop_start_test_test Assisted-by: Jetski:Gemini
SuperStrongDinosaur
force-pushed
the
fix_single_instance_start
branch
from
November 11, 2026 10:42
6313b33 to
e54c5e1
Compare
SuperStrongDinosaur
added
the
kokoro:force-run
GoogleCuttlefishTesterBot
removed
the
kokoro:force-run
SuperStrongDinosaur
added
the
kokoro:force-run
GoogleCuttlefishTesterBot
removed
the
kokoro:force-run
SuperStrongDinosaur
added
the
kokoro:force-run
GoogleCuttlefishTesterBot
removed
the
kokoro:force-run
SuperStrongDinosaur
disabled auto-merge
November 11, 2026 15:42
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Nov 11, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Nov 11, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Nov 11, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove the deprecated --report_anonymous_usage_stats flag from Host Orchestrator's Instance.Start, Group.Start, and StartOptions so per-instance start requests pass CanBypassToSingleInstance instead of falling through to group start and failing when peer instances are running. Also accept --report_anonymous_usage_stats in CanBypassToSingleInstance for backwards compatibility.
Update LaunchSingleInstance to pre-register only the target instance with the operator and stop only the target instance on boot failure so running sibling instances are not disrupted.
Bug: 581680503