Skip to content

Delete v1 metrics#2835

Open
cjreynol wants to merge 5 commits into
google:mainfrom
cjreynol:delete_v1_metrics
Open

Delete v1 metrics#2835
cjreynol wants to merge 5 commits into
google:mainfrom
cjreynol:delete_v1_metrics

Conversation

@cjreynol

Copy link
Copy Markdown
Collaborator

Remove the code and references to the v1 metrics. Primarily, this removes the prompt for report_anonymous_usage_stats. We will also no longer transmit those events, but we have v2 metrics in cvd now capturing major events.

Bug: 463443661

@cjreynol cjreynol self-assigned this Jul 10, 2026
@cjreynol cjreynol added kokoro:force-run Trigger a presubmit build unconditionally. kokoro:run Run e2e tests. labels Jul 10, 2026
@GoogleCuttlefishTesterBot GoogleCuttlefishTesterBot removed kokoro:run Run e2e tests. kokoro:force-run Trigger a presubmit build unconditionally. labels Jul 10, 2026
@cjreynol
cjreynol force-pushed the delete_v1_metrics branch from 7adae31 to b015a2c Compare July 10, 2026 22:06
@cjreynol cjreynol added kokoro:force-run Trigger a presubmit build unconditionally. kokoro:run Run e2e tests. labels Jul 10, 2026
@cjreynol
cjreynol requested a review from Databean July 10, 2026 22:07
@cjreynol
cjreynol marked this pull request as ready for review July 10, 2026 22:07
@GoogleCuttlefishTesterBot GoogleCuttlefishTesterBot removed kokoro:run Run e2e tests. kokoro:force-run Trigger a presubmit build unconditionally. labels Jul 10, 2026
@cjreynol

Copy link
Copy Markdown
Collaborator Author

Do not merge until other relevant changes have first been merged.

@cjreynol

Copy link
Copy Markdown
Collaborator Author

Other relevant changes have been merged.

@cjreynol cjreynol added kokoro:force-run Trigger a presubmit build unconditionally. kokoro:run Run e2e tests. labels Jul 13, 2026
@GoogleCuttlefishTesterBot GoogleCuttlefishTesterBot removed kokoro:run Run e2e tests. kokoro:force-run Trigger a presubmit build unconditionally. labels Jul 13, 2026
@cjreynol
cjreynol force-pushed the delete_v1_metrics branch from b015a2c to 1aae572 Compare July 16, 2026 01:57
cjreynol added 5 commits July 16, 2026 15:31
With the v1 metrics code deleted, the only code left is for the
`metrics_transmitter` binary.  Rename the directory to match that
purpose.

Bug: 463443661
And the transitive deletions that follow from those.

Keep the `report_anonymous_usage_stats` flag definitions to avoid
breaking compatibility, but no longer use those values.

Leaving the proto field in the definition to avoid a breaking change for
now, but only old branches will continue to transmit it.

Bug: 463443661
The field corresponded to the `report_anonymous_usage_stats` flag, which
is now deprecated and unused.

Marking the field as deprecated with a comment, but leaving the field in
the definition to not break the existing validation logic.

Bug: 463443661
@cjreynol
cjreynol force-pushed the delete_v1_metrics branch from 1aae572 to 69f066d Compare July 16, 2026 22:41
@cjreynol cjreynol added kokoro:force-run Trigger a presubmit build unconditionally. kokoro:run Run e2e tests. and removed kokoro:force-run Trigger a presubmit build unconditionally. kokoro:run Run e2e tests. labels Jul 16, 2026
@cjreynol cjreynol added kokoro:force-run Trigger a presubmit build unconditionally. kokoro:run Run e2e tests. labels Jul 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kokoro:force-run Trigger a presubmit build unconditionally. kokoro:run Run e2e tests.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants