Delete v1 metrics#2835
Open
cjreynol wants to merge 5 commits into
Open
Conversation
cjreynol
force-pushed
the
delete_v1_metrics
branch
from
July 10, 2026 22:06
7adae31 to
b015a2c
Compare
cjreynol
marked this pull request as ready for review
July 10, 2026 22:07
Collaborator
Author
|
Do not merge until other relevant changes have first been merged. |
Databean
approved these changes
Jul 10, 2026
Collaborator
Author
|
Other relevant changes have been merged. |
cjreynol
force-pushed
the
delete_v1_metrics
branch
from
July 16, 2026 01:57
b015a2c to
1aae572
Compare
Bug: 463443661
Bug: 463443661
With the v1 metrics code deleted, the only code left is for the `metrics_transmitter` binary. Rename the directory to match that purpose. Bug: 463443661
And the transitive deletions that follow from those. Keep the `report_anonymous_usage_stats` flag definitions to avoid breaking compatibility, but no longer use those values. Leaving the proto field in the definition to avoid a breaking change for now, but only old branches will continue to transmit it. Bug: 463443661
The field corresponded to the `report_anonymous_usage_stats` flag, which is now deprecated and unused. Marking the field as deprecated with a comment, but leaving the field in the definition to not break the existing validation logic. Bug: 463443661
cjreynol
force-pushed
the
delete_v1_metrics
branch
from
July 16, 2026 22:41
1aae572 to
69f066d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove the code and references to the v1 metrics. Primarily, this removes the prompt for
report_anonymous_usage_stats. We will also no longer transmit those events, but we have v2 metrics incvdnow capturing major events.Bug: 463443661