test(cli): cover adk conformance test command options - #6874
Open
rootkiller6788 wants to merge 1 commit into
Open
test(cli): cover adk conformance test command options#6874rootkiller6788 wants to merge 1 commit into
rootkiller6788 wants to merge 1 commit into
Conversation
Add focused unit tests for the argument handling of `adk conformance test` (issue google#6730): multiple PATHS are all forwarded, --mode live is propagated, --streaming-mode bidi maps to the StreamingMode enum, and invalid --mode / --streaming-mode values are rejected by Click before any dispatch. The runner is mocked so the tests stay fast and deterministic, matching the existing conformance CLI tests in this module.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds focused unit tests for the
adk conformance testCLI command (requested in #6730). The command dispatches torun_conformance_test; the existing tests in this module already cover the no-path default, single-directory,--mode replay,--generate_report,--report_dir, and--streaming-mode ssecases. This change closes the remaining gaps:PATHSare all forwarded to the runner.--mode liveis propagated as"live".--streaming-mode bidiis parsed toStreamingMode.BIDI.--modevalue is rejected by Click (exit code 2) before any dispatch.--streaming-modevalue is rejected by Click (exit code 2) before any dispatch.The conformance runner is mocked (same pattern as the surrounding tests) so the suite stays fast and deterministic with no real LLM execution.
Why
These CLI behaviors had no automated coverage, leaving regressions in argument handling unguarded.
Testing
(5 new tests on top of the pre-existing conformance tests.)
pyink --checkandruff checkare clean on the changed file.