feat(cli) support extra packages in cloud deployments - #6860
Open
sylvesterkaczmarek wants to merge 1 commit into
Open
feat(cli) support extra packages in cloud deployments#6860sylvesterkaczmarek wants to merge 1 commit into
sylvesterkaczmarek wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to Issue or Description of Change
Problem
Agent Engine supports
--extra_packages, but Cloud Run and GKE deployments do not. Agents that share local Python packages therefore need duplicated code or custom deployment steps.Solution
--extra_packagesoption toadk deploy cloud_runandadk deploy gke./app/<basename>, and keep/apponPYTHONPATH.Testing Plan
pytest tests/unittests/cli/utils/test_cli_deploy_to_cloud_run.py tests/unittests/cli/utils/test_cli_deploy.py tests/unittests/cli/utils/test_cli_tools_click.py tests/unittests/cli/test_cli_tools_click_option_mismatch.py -q190 passed, 1 xfailed in 5.94sThe tests cover CLI forwarding, file and directory staging, generated Dockerfile instructions, existing Agent Engine behaviour, and Click option consistency.
All applicable pre-commit hooks passed.
Manual E2E
Not run against Cloud Run or GKE because that requires cloud credentials and billable resources. Unit tests build and inspect the exact deployment context and Dockerfile.
Checklist
Additional context
The option semantics match the existing Agent Engine flag so projects can use one package layout across all supported deployment targets.