Skip to content

Fix crash in additionalTokenRefreshParameters when emmSupport is nil #608

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
AkshatG6 wants to merge 2 commits into
base: main
Choose a base branch
from
+3 −1
Open

Fix crash in additionalTokenRefreshParameters when emmSupport is nil #608

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d01beca
Fix crash in additionalTokenRefreshParameters when emmSupport is nil
AkshatG6 Jul 23, 2026
c233c84
Added comment to GIDEMMSupport header file
AkshatG6 Jul 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions GoogleSignIn/Sources/GIDEMMSupport.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,8 @@ NS_ASSUME_NONNULL_BEGIN
(NSDictionary *)parameters;

/// Gets a new set of URL parameters that also contains EMM-related URL parameters if needed.
///
/// @note This function only returns parameter keys in the `NSDictionary` for string/number/bools.
+ (NSDictionary<NSString *,NSString *> *)parametersWithParameters:(NSDictionary *)parameters
emmSupport:(nullable NSString *)emmSupport
isPasscodeInfoRequired:(BOOL)isPasscodeInfoRequired;
Expand Down
2 changes: 1 addition & 1 deletion GoogleSignIn/Sources/GIDEMMSupport.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,7 @@ + (void)handleTokenFetchEMMError:(nullable NSError *)error
emmSupport:(nullable NSString *)emmSupport
isPasscodeInfoRequired:(BOOL)isPasscodeInfoRequired {
if (!emmSupport) {
return parameters;
return [GIDEMMSupport dictionaryWithStringValuesFromDictionary:parameters];
}
NSMutableDictionary *allParameters = [(parameters ?: @{}) mutableCopy];
allParameters[kEMMSupportParameterName] = emmSupport;
Expand Down
Loading