Skip to content

style: align codebase with Flutter style guide #332

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
stephenmcd wants to merge 1 commit into
base: main
Choose a base branch
from
Open

style: align codebase with Flutter style guide #332

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pay/example/integration_test/payment_flow_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ import 'package:pay/pay.dart';
void main() {
IntegrationTestWidgetsFlutterBinding.ensureInitialized();

testWidgets("correctly creates an instance of the client", (_) async {
testWidgets("correctly creates an instance of the client", (WidgetTester tester) async {
Pay client = Pay({});
await expectLater(client, isNotNull);
});
Expand Down
4 changes: 2 additions & 2 deletions pay/example/lib/advanced.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ void main() {
runApp(const PayAdvancedMaterialApp());
}

const googlePayEventChannelName = 'plugins.flutter.io/pay/payment_result';
const kGooglePayEventChannelName = 'plugins.flutter.io/pay/payment_result';

@JlUgia JlUgia Aug 5, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Keeping modifier prefixes out is favored by the effective Dart guide, which we've been following.

const _paymentItems = [
PaymentItem(
label: 'Total',
Expand Down Expand Up @@ -70,7 +70,7 @@ class PayAdvancedSampleApp extends StatefulWidget {
}

class _PayAdvancedSampleAppState extends State<PayAdvancedSampleApp> {
static const eventChannel = EventChannel(googlePayEventChannelName);
static const eventChannel = EventChannel(kGooglePayEventChannelName);
StreamSubscription<String>? _googlePayResultSubscription;

late final Future<bool> _canPayGoogleFuture;
Expand Down
1 change: 1 addition & 0 deletions pay_platform_interface/lib/core/payment_configuration.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ import 'package:flutter/services.dart';
import '../util/configurations.dart';

/// The payment providers supported by this package.
// ignore: constant_identifier_names
enum PayProvider { apple_pay, google_pay }

/// A type used to define the signature of methods and objects used to load
Expand Down
1 change: 1 addition & 0 deletions pay_platform_interface/lib/core/payment_item.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@
/// * [pending] expects changes to the final price in response to user selection
/// or other circumstances that are not known when first requesting the payment.
/// * [unknown] for any other scenario.
// ignore: constant_identifier_names
enum PaymentItemStatus { unknown, pending, final_price }

/// A set of utility methods associated to the [PaymentItemStatus] enumeration.
Expand Down