fix(text): interpolate token value in _normalize_token error message - #769
Open
erensh27 wants to merge 1 commit into
Open
fix(text): interpolate token value in _normalize_token error message#769erensh27 wants to merge 1 commit into
erensh27 wants to merge 1 commit into
Conversation
The message used a non-f-string literal with {token!r}, so the placeholder
was printed literally instead of the offending token. This made debugging
stop/forbidden token misconfigurations impossible.
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Author
|
CLA check done |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix for #658: the error message in
_normalize_token()used a plain string literal with{token!r}, so the placeholder was printed literally instead of the offending token value.Now the exception reports the actual token (e.g.
'hello world') instead of the raw placeholder, makingstop_tokens/forbidden_tokensmisconfigurations debuggable.Fixes #658