Repository navigation
bump CMake requirement to 3.25 - #120
Conversation
|
@enetheru What do you think? I don't know how important it is to support older versions of CMake. If it is important, then the other option is trying to not use these two features. Given my limited experience with CMake, I don't personally have an opinion either way |
|
Version 3.25 is also very old - year 2022. |
|
haha, awesome, @van800 I wonder how this came up, was it some tooling? or a person who noticed? but if we don't want to bump the versions, I don't think either of those features are necessary.
|
|
Oh man i didn't notice which repo we were in. |
|
I think remember now?, marking the inclusion of godot-cpp directory as SYSTEM prevents the godot-cpp files from being added to the install targets. but thats not relevant here, and is a pretty hacky solution for that. I think it can just be removed. |
|
I bumped into it while testing myself on an older Ubuntu while testing a fix. BTW, I managed to verify that my CI fails, when I set minimum required to 3.25 and install cmake 3.24 van800/godot-support#5
Version 3.17 was so poor, that it wasn't even able to communicate this error clearly, so I had to bump at least to 3.24 to see the error. |
dsnopek
left a comment
There was a problem hiding this comment.
I'm not a CMake expert, but this seems OK: if 3.25 is from 2022 (which is sufficiently old that most folks should already have it), and we already require this version due to SYSTEM and REQUIRED that means folks have already had to have this version or newer.
Using [SYSTEM] keyword added in CMake 3.25
https://cmake.org/cmake/help/v3.25/command/add_subdirectory.html?highlight=add_subdirectory
Aslo find_program(... REQUIRED) — added in 3.18
https://cmake.org/cmake/help/latest/command/find_program.html