This change normalizes filesystem event paths before comparing them with the configured watch sources - #2999
Open
SillyZir wants to merge 1 commit into
Open
This change normalizes filesystem event paths before comparing them with the configured watch sources#2999SillyZir wants to merge 1 commit into
SillyZir wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This change normalizes filesystem event paths before comparing them with the configured watch sources.
On Windows, filesystem event paths can use path separators that differ from the slash-separated paths used by the configured sources. The change applies filepath.ToSlash to the event path so the comparison uses a consistent representation.
The package tests pass in the pipeline environment.
The relevant verification environment was macOS, so this PR does not independently reproduce the reported Windows behavior. In particular, the implementation assumes the collected source paths are already represented with slash separators on Windows.
This PR addresses the path-normalization behavior described in #2862.
The code change in this PR was generated with the assistance of an engineering system I created, which I reviewed, understood, and validated.
Checklist