Repository navigation
rbtest: -perf.commit must equal the measured tree's HEAD - #13
Merged
Merged
Conversation
Refuse a -perf.commit that is not the exact 40-character HEAD of <root>, or a dirty tree (bench/go.mod and bench/go.sum excepted). Without the flag, record HEAD, suffixed -dirty when the tree is. No git: refuse only if the flag was given. Refs #12 Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Real-git tests for the status parser (dirty, untracked, rename, xbench, nested module); bench/go.mod exempt only for requires of other modules with the library's replace unchanged, go.sum only alongside it; -perf.record refuses a different commit and records the checked one; dirty marker carries a digest of the changes; untracked-files=all, ignore-submodules=none, GIT_* cleared, 30 s timeout, paths mapped under the module root. Refs #12 Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Fewer error branches (one batched git call), a goModAccepted table, hash-choice and outside-git tests. Refs #12 Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
This was referenced Nov 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #12
-perf.commitmust now equal the 40-charactergit rev-parse HEADof<root>, on a clean tree (onlybench/go.mod/bench/go.summay be dirty); otherwise the run refuses, naming both values or the dirty paths. Without the flag the commit is filled from HEAD, suffixed-dirtywhen the tree is. With no git, only a given flag refuses. The git lookup is replaceable; tests cover match, mismatch, prefix, dirty library file, dirty harness only, no git. README updated.🤖 Generated with Claude Code