Repository navigation
docs: reconcile stale GEMM perf claims with current BENCHMARKS/perf.md - #2
Merged
Merged
Conversation
README.md's perf paragraph and docs/plan-ndarray.md's Performance phase still cited the pre-by-lane-FMLA GEMM numbers (~156 GFLOP/s, ~76% of OpenBLAS) and listed SIMD Sqrt/Max plus the cache-blocked GEMM as "Still TODO" / "IN PROGRESS" — all superseded once the by-lane FMLA micro-kernel landed. docs/perf.md already records tuned-BLAS parity at n=1024 (~203 GFLOP/s, ~0.99x OpenBLAS), and the newer BENCHMARKS.md (Apple M4 Max) records ~373 GFLOP/s at ~1.00x single-threaded vecLib plus a 4-10x win over the pure-Go gonum — neither of which the top-level README or roadmap mentioned. Bring both up to date, matching the wording already reconciled in the sibling go-ndarray/docs repo's roadmap.md. No library code touched. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
docs/perf.md(tuned-BLAS parity at n=1024, ~203 GFLOP/s, ~0.99x OpenBLAS) and never mentioned the newerBENCHMARKS.md(Apple M4 Max, ~373 GFLOP/s at ~1.00x single-threaded vecLib, beats the pure-Gogonum4-10x).docs/plan-ndarray.md's "Performance" phase was still marked "IN PROGRESS" with "Still TODO: SIMD Sqrt/Max ... a tuned OpenBLAS/MKL would lead" even though those are done — updated to mirror the wording already reconciled in the siblinggo-ndarray/docsrepo'sroadmap.md.docs/perf.md,BENCHMARKS.md).Test plan
GOWORK=off go build ./...GOWORK=off go vet ./...GOWORK=off go test ./...🤖 Generated with Claude Code