Repository navigation
test: compile and run the suite on 32-bit targets; pin the asm generator - #10
Merged
Merged
Conversation
overflow_test.go wrote its overflowing shapes as 1<<62 and 1<<40 literals, which do not compile where int is 32 bits, so `go test` failed to build on linux/386, arm, mips and mipsle. The extents are now derived from bits.UintSize, so the same products overflow on both word sizes; the suite passes on real 386 hardware. Nothing caught this because CI never ran a 32-bit target. Three lanes now cover it: - arch 386: GOARCH=386 natively on the amd64 runner (not qemu-i386). - arch arm (qemu): a 32-bit ARM lane beside the existing qemu ones. - compile tests on every target: `go test -c` for each `go tool dist list` pair (`go vet` for android/ios, which cannot link without cgo). Checked with a planted 1<<62 literal, which both modes refuse. The asm generators carried //go:build ignore, so `go mod tidy` saw no import of go-asmgen and dropped the requirement. Renovate's "update to v0.9.0" (#6) did exactly that, leaving CI to resolve whatever version -mod=mod found. The tag is gone (each generator is the only file of its own main package), and go-asmgen is pinned at v0.10.0 again, which regenerates the committed .s byte for byte. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
overflow_test.go wrote its overflowing shapes as 1<<62 and 1<<40 literals,
which do not compile where int is 32 bits, so
go testfailed to build onlinux/386, arm, mips and mipsle. The extents are now derived from
bits.UintSize, so the same products overflow on both word sizes; the suite
passes on real 386 hardware.
Nothing caught this because CI never ran a 32-bit target. Three lanes now
cover it:
go test -cfor eachgo tool dist listpair (
go vetfor android/ios, which cannot link without cgo). Checkedwith a planted 1<<62 literal, which both modes refuse.
The asm generators carried //go:build ignore, so
go mod tidysaw noimport of go-asmgen and dropped the requirement. Renovate's "update to
v0.9.0" (#6) did exactly that, leaving CI to resolve whatever version
-mod=mod found. The tag is gone (each generator is the only file of its
own main package), and go-asmgen is pinned at v0.10.0 again, which
regenerates the committed .s byte for byte.
🤖 Generated with Claude Code