fix(actions): don't show branch-filtered push workflows as skipped in pull requests#38365
Open
bircni wants to merge 1 commit into
Open
fix(actions): don't show branch-filtered push workflows as skipped in pull requests#38365bircni wants to merge 1 commit into
bircni wants to merge 1 commit into
Conversation
Contributor
|
Now the behavior is:
Do we want to keep this behavior inconsistent? AFAIK, GitHub doesn't create a commit status for either type of mismatch. |
wxiaoguang
previously approved these changes
Jul 8, 2026
wxiaoguang
left a comment
Contributor
There was a problem hiding this comment.
rubberstamp approve since I haven't really looked into the details, while the code itself looks good.
wait for more feedbacks for #38365 (comment)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #38351
Problem
A
push-only workflow shows up as Skipped inside pull requests, where it should not appear at all.Given two workflows:
Opening a PR from a feature branch surfaces the
pushworkflow as a skipped check in the PR.Cause
#38237 fixed required status checks getting stuck Pending when a workflow is excluded by a
pathsfilter, by posting aCommitStatusSkippedstatus for filtered-out workflows. ButmatchPushEvent/matchPullRequestEventreturneddetectFilteredOutfor any filter mismatch — including a branch/tag mismatch.So pushing to a feature branch, where the
pushworkflow'sbranches: [main]filter excludes the ref, posted a skippedpushstatus on that commit. Because the commit is the PR's head, the status leaked into the PR's checks.