fix(pull): re-evaluate review official flag on target branch change#38319
Open
bircni wants to merge 1 commit into
Open
fix(pull): re-evaluate review official flag on target branch change#38319bircni wants to merge 1 commit into
bircni wants to merge 1 commit into
Conversation
The official flag of a pull request review is computed against the target branch's protection rules when the review is submitted and stored on the review record. Changing the target branch did not re-evaluate it, so an official approval obtained against an unprotected branch could be retargeted onto a protected branch and satisfy its required approvals. Re-evaluate the official flag of the latest approve/reject reviews against the new base branch whenever the target branch changes. Assisted-by: Claude:claude-opus-4-8
GiteaBot
added
the
lgtm/need 2
lafriks
reviewed
Jul 5, 2026
| return err | ||
| } | ||
| if official { | ||
| if _, err := db.Exec(ctx, "UPDATE `review` SET official=? WHERE id=?", true, review.ID); err != nil { |
Member
There was a problem hiding this comment.
Why use direct update not builder? 🤔
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
officialflag of a pull request review is computed against the target branch's protection rules at submit time and stored on the review record.ChangeTargetBranchupdated the base branch but never re-evaluated it, so anofficialapproval obtained against an unprotected branch could be retargeted onto a protected branch and satisfy its required approvals, bypassing the branch protection.This re-evaluates the
officialflag of the latest approve/reject reviews against the new base branch whenever the target branch changes.