Repository navigation
Dispatch a user-defined #!= instead of inverting #== in the != opcode - #572
Merged
Merged
Conversation
rbgo compiled `a != b` to OpNeq, which binaryOp evaluated as !(a == b) — so a class that overrides #!= (as MRI's BasicObject#!= documents callers may) was ignored: `C.new != x` returned !(C#==) rather than C#!=. This surfaced across core/array, core/range and core/bsearch specs and the mspec ShouldProxy harness. OpNeq now dispatches the receiver's #!= when its class overrides it anywhere below BasicObject (whose default #!= is still the inline !(self == other) fast path); built-in value types, which never override #!=, are unaffected. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
a != bcompiled to OpNeq and was evaluated as!(a == b), ignoring a user-defined#!=(which MRI dispatches).C.new != xreturned!(C#==)instead ofC#!=. This was flagged by three separate conformance efforts (array/range/bsearch specs + the mspec ShouldProxy harness). OpNeq now dispatches the receiver's#!=when its class overrides it below BasicObject; the default!(self == other)inline path is kept for everything else (built-in value types never override#!=). Every changed function is 100% covered;go test ./..., wasip1 wasm and gofmt all green; FLOOR untouched.🤖 Generated with Claude Code