Repository navigation
Maintain $. and $_ across the IO#gets line-reader family - #520
Merged
Merged
Conversation
IO#gets / #readline advanced the IOObj's own #lineno but never updated the $. (line number) and $_ (last read line) globals, so a spec (or program) that inspects them after a read saw the stale value. Now gets and readline set both $. and $_ (a StringIO updates them too, matching MRI); reading past the last line clears $_ while $. keeps the final number; and the bulk readers #readlines / #each_line advance $. but leave $_ untouched, as MRI does. core/io/gets_spec 21 -> 26, readline_spec 9 -> 10, each_line_spec 18 -> 19, no regressions. ruby/spec ratchet FLOOR 17300 -> 17310 (measured 17351). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
IO#gets/#readlineadvanced the IOObj's own#linenobut never updated the$.(line number) and$_(last read line) globals, so a spec or program inspecting them after a read saw the stale value.Now (verified byte-for-byte against MRI Ruby 4.0.6):
getsandreadlineset both$.and$_(aStringIOupdates them too);$_while$.keeps the final line number;#readlines/#each_lineadvance$.but leave$_untouched.Conformance:
core/io/gets_spec21→26,readline_spec9→10,each_line_spec18→19; no regressions. FLOOR 17300 → 17310 (measured total 17351).go test ./...green, native +wasip1/wasmbuild, gofmt clean, 100% merged coverage.🤖 Generated with Claude Code