Repository navigation
Bump ruby/spec FLOOR 16990 -> 17270 - #518
Merged
Merged
Conversation
Lock in a second cluster of conformance merges: Symbol#inspect quoting, full-Unicode regex POSIX classes (go-regexp/engine v0.1.2), Marshal dump/load, Numeric#step + Enumerator::ArithmeticSequence, and the Time constructor argument forms. Measured total is 17316 passing examples (files loaded 2162, failed 44); the floor is set below that with margin for slower CI hardware. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
The Marshal conformance test's sym_encoded_roundtrip case expected the non-ASCII symbol :€x to inspect as the quoted :"€x", which was rbgo's behaviour when that test was written but not MRI's. It was authored in parallel with the Symbol#inspect fix (#513) that made non-ASCII symbols print bare (:€x, matching MRI 4.0), so once both merged the expectation was stale and failed. Assert the correct MRI output. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Locks in a second cluster of conformance merges (all left
FLOORuntouched so they could merge in any order):Symbol#inspectMRI 4.0 quoting rules (Match MRI 4.0 Symbol#inspect quoting rules #513)character_classes83→120 (Bump go-regexp/engine: full-Unicode POSIX character classes (+37) #514)Marshaldump/load (Advance Marshal MRI conformance: symbols, Bignum links, exceptions, depth limit #516)Numeric#step+Enumerator::ArithmeticSequence— step 119→184 (Add Enumerator::ArithmeticSequence and MRI-exact Numeric#step arg errors #515)Timeconstructor argument forms (String/zone-object/coercion) — core/time 371→473 (Time: MRI 4.0 constructor argument forms (String/zone-object/coercion) #517)Measured total: 17316 passing examples (files loaded 2162, failed 44). FLOOR 16990 → 17270, below the measured total with margin for slower CI hardware.
🤖 Generated with Claude Code