Repository navigation
Add the private Time#_dump / Time._load Marshal hooks - #501
Merged
Merged
Conversation
tannevaled
force-pushed
the
feat/time-dump
branch
2 times, most recently
from
August 30, 2026 09:30
cb599ee to
14326f0
Compare
Time#_dump packs a Time into MRI's 8-byte marshal form (extracted from the Marshal codec's writeTime into a shared timeDumpBytes) and Time._load rebuilds a Time from those bytes. Both are private (as MRI has them): _dump an instance method absent from respond_to?, _load a private class method. Marshal round-trips are unchanged. Verified against ruby 4.0.6. Whole-package coverage stays at 100%; the ruby/spec floor rises to 16290 (core/time/_dump 0 -> 5, _load 0 -> 2, marshal/dump +1). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
tannevaled
force-pushed
the
feat/time-dump
branch
from
August 30, 2026 10:07
14326f0 to
eaa5834
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Time#_dumppacks a Time into MRI's 8-byte marshal form (extracted from theMarshal codec's
writeTimeinto a sharedtimeDumpBytes) andTime._loadrebuilds a Time from those bytes. Both are private (as MRI has them):
_dumpan instance method absent from
respond_to?,_loada private class method.Marshal round-trips are unchanged.
Verified against ruby 4.0.6. Whole-package coverage stays at 100%; the ruby/spec
ratchet floor rises to 16290 (
core/time/_dump0 → 5,_load0 → 2,marshal/dump+1, zero regressions in a per-file sweep).🤖 Generated with Claude Code