Repository navigation
IO: add fileno / to_i (synthetic descriptors) - #482
Merged
Merged
Conversation
IO#fileno (and its #to_i alias) returns the stream's descriptor: the standard streams report 0/1/2, and any other IO gets a distinct synthetic descriptor, assigned on first request and stable thereafter. rbgo has no real OS file descriptors, so this is an identity rather than a kernel fd, and it is defined only on IO (not StringIO). A closed stream raises IOError. Verified against ruby 4.0.6. Whole-package coverage stays at 100%; the ruby/spec floor rises 16170 -> 16180 (core/io fileno +2, new +7, plus open/for_fd). The real-fd operations (IO.for_fd round-trips) remain out of reach of the in-memory IO model. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
IO#fileno(and its#to_ialias) returns the stream's descriptor: the standardstreams report 0/1/2, and any other IO gets a distinct synthetic descriptor,
assigned on first request and stable thereafter. rbgo has no real OS file
descriptors, so this is an identity rather than a kernel fd, and it is defined
only on
IO(notStringIO). A closed stream raisesIOError.Verified against ruby 4.0.6. Whole-package coverage stays at 100%; the ruby/spec
ratchet floor rises 16170 → 16180 (
core/iofileno +2, new +7, plus open/for_fd,zero regressions in a per-file sweep). The real-fd operations (
IO.for_fdround-trips) remain out of reach of the in-memory IO model.
🤖 Generated with Claude Code