Repository navigation
ARGF: per-unit iterators, byte reads, file, and true method aliases - #481
Merged
Merged
Conversation
Extend ARGF with the character/byte iteration protocol and tidy its aliases: - each_byte / each_char / each_codepoint yield every unit across the files (an Enumerator with no block), and getbyte / readbyte read a single byte. - file returns the IO of the file currently being read. - eof, path, to_a and each are now true aliases of eof?, filename, readlines and each_line (sharing the method record), so MRI's Method-equality specs pass. Verified against ruby 4.0.6. Whole-package coverage stays at 100%; the ruby/spec floor rises 16150 -> 16170 (core/argf 42 -> 61). fileno/to_i, seek/pos/rewind and set_encoding still await the fd layer. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extends ARGF with the character/byte iteration protocol and tidies its aliases:
each_byte/each_char/each_codepointyield every unit across thefiles (an Enumerator with no block), and
getbyte/readbyteread asingle byte.
filereturns the IO of the file currently being read.eof,path,to_aandeachare now true aliases ofeof?,filename,readlinesandeach_line(sharing the method record), so MRI'sMethod-equality specs pass.Verified against ruby 4.0.6. Whole-package coverage stays at 100%; the ruby/spec
ratchet floor rises 16150 → 16170 (
core/argf42 → 61, zero regressions in aper-file sweep).
fileno/to_i,seek/pos/rewindandset_encodingstillawait the fd layer.
🤖 Generated with Claude Code