Skip to content

IO: add external_encoding, internal_encoding and set_encoding - #478

Merged
tannevaled merged 1 commit into
mainfrom
feat/io-encoding
Aug 28, 2026
Merged

tannevaled merged 1 commit into
mainfrom
feat/io-encoding

Conversation

@tannevaled

Copy link
Copy Markdown
Contributor

IO streams now carry an external/internal encoding pair (new IOObj.extEnc /
intEnc fields) — the first step of the encoding subsystem:

  • external_encoding returns the explicitly-set encoding, else
    Encoding.default_external — except a write-only stream with no encoding and
    no default internal encoding, which reports nil, as MRI does.
  • internal_encoding returns the set internal encoding, or nil.
  • set_encoding(ext, int = nil) accepts an Encoding, an encoding name, or a
    combined "external:internal" string (a nil argument clears that side) and
    returns self; an unknown name raises ArgumentError, a non-String/Encoding
    argument a TypeError.

Verified against ruby 4.0.6. Whole-package coverage stays at 100%; the ruby/spec
ratchet floor rises 15905 → 16080 (core/io external_encoding 0→59,
internal_encoding 0→79, set_encoding 0→21, +166 aggregate, zero regressions in a
deterministic per-file sweep).

🤖 Generated with Claude Code

IO streams now carry an external/internal encoding pair (new IOObj.extEnc /
intEnc fields):

- external_encoding returns the explicitly-set encoding, else Encoding
  .default_external — except a write-only stream with no encoding and no default
  internal encoding, which reports nil, as MRI does.
- internal_encoding returns the set internal encoding, or nil.
- set_encoding(ext, int = nil) accepts an Encoding, an encoding name, or a
  combined "external:internal" string (a nil argument clears that side) and
  returns self; an unknown name raises ArgumentError and a non-String/Encoding
  argument a TypeError.

Verified against ruby 4.0.6. Whole-package coverage stays at 100%; the ruby/spec
floor rises 15905 -> 16080 (core/io external_encoding 0->59, internal_encoding
0->79, set_encoding 0->21).

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
@tannevaled
tannevaled merged commit 7a41b90 into main Aug 28, 2026
7 checks passed
@tannevaled
tannevaled deleted the feat/io-encoding branch August 28, 2026 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant