Repository navigation
IO::Buffer: add #slice and #resize - #477
Merged
Merged
Conversation
Follow-up to the initial IO::Buffer, adding the two deferred memory operations: - slice(offset = 0, length = size - offset) returns a buffer sharing this buffer's memory over the range, so a write through the slice shows in the original. It inherits the read-only flag, reports as neither internal nor external (it owns no allocation), and can itself be resized; an out-of-range range raises ArgumentError. - resize(size) reallocates, preserving the leading bytes (a larger buffer is zero-filled) and marking the buffer internal; an external buffer (.for / .string) cannot be resized and raises AccessError. Verified against ruby 4.0.6. Whole-package coverage stays at 100%; the ruby/spec floor rises 15890 -> 15905 (core/io/buffer resize +7 plus slice/internal/external). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to the initial IO::Buffer, adding the two deferred memory operations:
slice(offset = 0, length = size - offset)returns a buffer sharing thisbuffer's memory over the range, so a write through the slice shows in the
original. It inherits the read-only flag, reports as neither internal nor
external (it owns no allocation), and can itself be resized; an out-of-range
range raises
ArgumentError.resize(size)reallocates, preserving the leading bytes (a larger buffer iszero-filled) and marking the buffer internal; an external buffer (
.for/.string) cannot be resized and raisesAccessError.Verified against ruby 4.0.6. Whole-package coverage stays at 100%; the ruby/spec
ratchet floor rises 15890 → 15905 (
core/io/bufferresize +7 plusslice/internal/external, +17 aggregate, zero regressions in a per-file sweep).
🤖 Generated with Claude Code