Repository navigation
Add MatchData#bytebegin, #byteend and #byteoffset - #474
Merged
Merged
Conversation
These are the byte-index counterparts of #begin / #end / #offset (Ruby 3.2+): they return the raw byte position of a group's start and end, skipping the byte-to-character conversion that the character-offset methods apply. A group that did not participate yields nil (or [nil, nil]); an unknown index or name raises IndexError, matching the existing methods. Verified against ruby 4.0.6. Whole-package coverage stays at 100%; the ruby/spec floor rises 15850 -> 15870 (core/matchdata bytebegin +13, byteend +10, byteoffset +8). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The byte-index counterparts of
#begin/#end/#offset(Ruby 3.2+): theyreturn the raw byte position of a group's start and end, skipping the
byte-to-character conversion the character-offset methods apply. A group that did
not participate yields
nil(or[nil, nil]); an unknown index or name raisesIndexError, matching the existing methods.Verified against ruby 4.0.6. Whole-package coverage stays at 100%; the ruby/spec
ratchet floor rises 15850 → 15870 (
core/matchdatabytebegin +13, byteend +10,byteoffset +8 = +31, zero regressions in a deterministic per-file sweep).
🤖 Generated with Claude Code