Repository navigation
Add String#unicode_normalize! - #472
Merged
Merged
Conversation
The in-place form was missing (unicode_normalize / unicode_normalized? already existed). It normalizes the receiver's bytes and returns self, even when the string is already normalized. The form argument is validated (ArgumentError for an unknown form) before the frozen check (FrozenError), matching MRI's order. Verified against ruby 4.0.6. Whole-package coverage stays at 100%; the ruby/spec floor rises 15830 -> 15840 (core/string/unicode_normalize 6 -> 12). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The in-place form was missing (
unicode_normalize/unicode_normalized?already existed).
unicode_normalize!normalizes the receiver's bytes andreturns
self, even when the string is already normalized. The form argument isvalidated (
ArgumentErrorfor an unknown form) before the frozen check(
FrozenError), matching MRI's order.Verified against ruby 4.0.6. Whole-package coverage stays at 100%; the ruby/spec
ratchet floor rises 15830 → 15840 (
core/string/unicode_normalize6 → 12, zeroregressions in a deterministic per-file sweep).
🤖 Generated with Claude Code