Repository navigation
Numeric: zero?, real, floor, ceil, round, truncate fallbacks - #469
Merged
Merged
Conversation
A Numeric subclass that defines only #to_f (and #<=>) inherited none of these, so zero? / real / floor / ceil / round / truncate raised NoMethodError (and #nonzero?, which dispatches through #zero?, broke with it). They now delegate the way MRI does: zero? is self == 0 (honouring a subclass's own #== / #<=>), real returns self, and floor / ceil / round / truncate operate on #to_f, forwarding the optional digits argument to Float. Integer and Float keep their own overrides. Verified against ruby 4.0.6. Whole-package coverage stays at 100%; the ruby/spec floor rises 15800 -> 15810 (core/numeric +6). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A
Numericsubclass that defines only#to_f(and#<=>) inherited none ofthese, so
zero?/real/floor/ceil/round/truncateraisedNoMethodError— and#nonzero?, which dispatches through#zero?, broke withit.
They now delegate the way MRI does:
zero?isself == 0(honouring a subclass'sown
#==/#<=>),realreturnsself, andfloor/ceil/round/truncateoperate on#to_f, forwarding the optional digits argument toFloat.IntegerandFloatkeep their own overrides.Verified against ruby 4.0.6. Whole-package coverage stays at 100%; the ruby/spec
ratchet floor rises 15800 → 15810 (
core/numeric+6, zero regressions in adeterministic per-file sweep).
🤖 Generated with Claude Code