Repository navigation
Add the IO seek constants and mix File::Constants into IO - #460
Merged
Merged
Conversation
IO had no SEEK_SET/SEEK_CUR/SEEK_END (nor SEEK_DATA/SEEK_HOLE) constants, and did not mix in File::Constants, so IO::SEEK_SET and IO::RDONLY were uninitialized constants. The seek-whence constants are now defined on IO — File inherits them since File < IO — and IO includes the File::Constants module, so the open-mode flags resolve through IO (IO::RDONLY, IO.include?(File::Constants)) as in MRI. Verified against ruby 4.0.6. Full package coverage stays at 100.0%. Zero- regression rubyspec sweep; core/io/constants_spec 0 -> 3, and the newly-defined whence constants also unblock core/io/seek_spec 2 -> 8 and core/io/sysseek_spec 1 -> 5. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
IO had no
SEEK_SET/SEEK_CUR/SEEK_END(norSEEK_DATA/SEEK_HOLE)constants, and did not mix in
File::Constants, soIO::SEEK_SETandIO::RDONLYwere uninitialized constants. The seek-whence constants are nowdefined on IO — File inherits them since
File < IO— and IO includes theFile::Constantsmodule, so the open-mode flags resolve through IO (IO::RDONLY,IO.include?(File::Constants)) as in MRI.Verified against ruby 4.0.6. Full package coverage stays at 100.0%.
Zero-regression rubyspec sweep;
core/io/constants_spec0 → 3, and thenewly-defined whence constants also unblock
core/io/seek_spec2 → 8 andcore/io/sysseek_spec1 → 5.🤖 Generated with Claude Code