Repository navigation
Integer#& / #| / #^: run the coerce protocol on a non-Integer operand - #455
Merged
Merged
Conversation
The bitwise operators fed their right operand straight through bigArg, which
raised "X can't be coerced into Integer" for anything that was not already an
Integer or Bignum. MRI instead runs the numeric coerce protocol: for an operand
that defines #coerce, rhs.coerce(self) yields a [x, y] pair and the operator is
re-dispatched on it, so `6 | obj` where obj.coerce(6) == [6, 3] returns 7.
A Float is the documented exception — MRI does not coerce a Float bitwise
operand — so a Float (and any operand without #coerce) still raises a TypeError,
and a #coerce that does not return a two-element array raises
"coerce must return [x, y]". The TypeError now names the operand's real class via
vm.classOf rather than the static classNameOf.
Verified against ruby 4.0.6. Full package coverage stays at 100.0%. Zero-
regression rubyspec sweep; core/integer/{bit_and,bit_or,bit_xor}_spec each +1.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The bitwise operators fed their right operand straight through
bigArg, whichraised
X can't be coerced into Integerfor anything that was not already anInteger or Bignum. MRI instead runs the numeric coerce protocol: for an
operand that defines
#coerce,rhs.coerce(self)yields a[x, y]pair and theoperator is re-dispatched on it, so
6 | objwhereobj.coerce(6) == [6, 3]returns
7.A Float is the documented exception — MRI does not coerce a Float bitwise operand
— so a Float (and any operand without
#coerce) still raises aTypeError, anda
#coercethat does not return a two-element array raisescoerce must return [x, y]. TheTypeErrornow names the operand's real classvia
vm.classOfrather than the staticclassNameOf.Verified against ruby 4.0.6. Full package coverage stays at 100.0%.
Zero-regression rubyspec sweep;
core/integer/{bit_and,bit_or,bit_xor}_speceach +1.
🤖 Generated with Claude Code