Repository navigation
Add String#hex - #447
Merged
Merged
Add String#hex#447
Conversation
String#hex was undefined (NoMethodError). It reads the string as a base-16 integer: an optional leading sign, an optional "0x"/"0X" prefix (b/d/o are hex digits, so no other radix prefix is special), hex digits with a single underscore allowed between them, stopping at the first non-hex character and returning 0 when no digit is present; a value beyond a machine word yields a Bignum. The digit scan, underscore rule, and Bignum conversion are factored out of strOct into a shared accumInum (with inumSignSkip for the leading sign), so String#oct and String#hex share one implementation rather than a copy. Verified against ruby 4.0.6. Full package coverage stays at 100.0%. Zero- regression rubyspec sweep; core/string/hex_spec 0 -> 7, core/string/oct_spec unchanged at 17. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
String#hexwas undefined (NoMethodError). It reads the string as a base-16integer: an optional leading sign, an optional
0x/0Xprefix (b/d/oarehex digits, so no other radix prefix is special), hex digits with a single
underscore allowed between them, stopping at the first non-hex character and
returning 0 when no digit is present; a value beyond a machine word yields a
Bignum.
The digit scan, underscore rule, and Bignum conversion are factored out of
strOctinto a sharedaccumInum(withinumSignSkipfor the leading sign), soString#octandString#hexshare one implementation rather than a copy.Verified against ruby 4.0.6. Full package coverage stays at 100.0%.
Zero-regression rubyspec sweep;
core/string/hex_spec0 → 7,core/string/oct_specunchanged at 17.🤖 Generated with Claude Code