Skip to content

String#%: convert the argument with #to_ary - #438

Merged
tannevaled merged 1 commit into
mainfrom
feat/cluster11
Aug 24, 2026
Merged

tannevaled merged 1 commit into
mainfrom
feat/cluster11

Conversation

@tannevaled

Copy link
Copy Markdown
Contributor

String#% only spread an Array argument and otherwise treated the
whole right-hand side as a single value, so "%d %d" % obj where obj
responds to #to_ary raised can't convert Object into Integer (too
few arguments) instead of using the converted array.

The argument is now turned into the positional list by a VM-aware
vmFormatArgs: an Array spreads, a Hash is kept whole for
%{name}/%<name> references, and any other object is converted with
#to_ary when it responds — an Array result spreads, a nil result
falls back to a single argument, and a non-Array result raises the MRI
TypeError ("can't convert X to Array (X#to_ary gives Y)"); a scalar
with no #to_ary stays a single argument. The old location-agnostic
formatArgs (now unused) is removed.

Verified against ruby 4.0.6; core/string/modulo_spec 235 → 245
with no regressions and the whole-suite coverage gate stays at 100.0%.

🤖 Generated with Claude Code

String#% only spread an Array argument and otherwise treated the whole
right-hand side as a single value, so `"%d %d" % obj` where obj responds
to #to_ary raised "can't convert Object into Integer" (too few
arguments) instead of using the converted array.

The argument is now turned into the positional list by a VM-aware
vmFormatArgs: an Array spreads, a Hash is kept whole for %{name}/%<name>
references, and any other object is converted with #to_ary when it
responds — an Array result spreads, a nil result falls back to a single
argument, and a non-Array result raises the MRI TypeError
("can't convert X to Array (X#to_ary gives Y)"); a scalar with no
#to_ary stays a single argument. The old location-agnostic formatArgs
(now unused) is removed.

Verified against ruby 4.0.6; core/string/modulo_spec 235 -> 245.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
@tannevaled
tannevaled merged commit 0cc8132 into main Aug 24, 2026
7 checks passed
@tannevaled
tannevaled deleted the feat/cluster11 branch August 24, 2026 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant