Repository navigation
String#%: convert the argument with #to_ary - #438
Merged
Merged
Conversation
String#% only spread an Array argument and otherwise treated the whole
right-hand side as a single value, so `"%d %d" % obj` where obj responds
to #to_ary raised "can't convert Object into Integer" (too few
arguments) instead of using the converted array.
The argument is now turned into the positional list by a VM-aware
vmFormatArgs: an Array spreads, a Hash is kept whole for %{name}/%<name>
references, and any other object is converted with #to_ary when it
responds — an Array result spreads, a nil result falls back to a single
argument, and a non-Array result raises the MRI TypeError
("can't convert X to Array (X#to_ary gives Y)"); a scalar with no
#to_ary stays a single argument. The old location-agnostic formatArgs
(now unused) is removed.
Verified against ruby 4.0.6; core/string/modulo_spec 235 -> 245.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
String#%only spread anArrayargument and otherwise treated thewhole right-hand side as a single value, so
"%d %d" % objwhereobjresponds to
#to_aryraisedcan't convert Object into Integer(toofew arguments) instead of using the converted array.
The argument is now turned into the positional list by a VM-aware
vmFormatArgs: anArrayspreads, aHashis kept whole for%{name}/%<name>references, and any other object is converted with#to_arywhen it responds — an Array result spreads, anilresultfalls back to a single argument, and a non-Array result raises the MRI
TypeError("can't convert X to Array (X#to_ary gives Y)"); a scalarwith no
#to_arystays a single argument. The old location-agnosticformatArgs(now unused) is removed.Verified against ruby 4.0.6;
core/string/modulo_spec235 → 245with no regressions and the whole-suite coverage gate stays at 100.0%.
🤖 Generated with Claude Code