Repository navigation
Implement top-level define_method - #430
Merged
Merged
Conversation
At the top level `define_method` raised NoMethodError, because `main`
had no such method. main's singleton class now gets `define_method`,
forwarding to Object's Module method (Object is the top-level default
definee): define_method(:m){…} defines Object#m and returns the method
name.
Verified against ruby 4.0.6; core/main/define_method_spec now passes 3/3.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
At the top level,
define_methodraisedNoMethodErrorbecausemainhad no such method.
main's singleton class now getsdefine_method,forwarding to Object's
Module#define_method(Object is the top-leveldefault definee):
define_method(:m){…}definesObject#mand returnsthe method name.
Verified against ruby 4.0.6;
core/main/define_method_specnow passes3/3. A full language+core sweep shows +3 with no regressions and thewhole-suite coverage gate stays at 100.0%.
(A top-level
includewas prototyped too but deferred: making itactually mix a module into Object — correct MRI behaviour — shifts
constant resolution enough to regress
core/module/constants_spec, soit needs a separate look.)
🤖 Generated with Claude Code