Repository navigation
ci: the watcher must not fail a run the ratchet passed - #426
Merged
Merged
Conversation
I added a watcher to this lane to find out what it was running out of. It found five memory blowups. It also, twice, turned a successful run into a red one: passing examples: 15005 (files loaded: 2135, failed to load: 71) frozen floor: 14900 note: 105 more passing than the floor ruby/spec ratchet OK Terminated ##[error]Process completed with exit code 1 The ratchet passed and the step failed, in tearing the watcher down. An EXIT trap did that, and the status the step ended with was whatever the trap left behind. The status is taken from the ratchet before anything is killed, and handed back explicitly. The race is not reproducible on demand, which is a reason to remove the mechanism rather than to keep timing it. Checked both ways: a ratchet exiting 0 gives a step exiting 0, and a ratchet exiting 1 still gives a step exiting 1 — the guard must not swallow a real failure to avoid a false one.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I added a watcher to this lane (#412) to find out what it was running out of. It found five memory blowups. It also, twice, turned a successful run into a red one:
The ratchet passed. The step failed in tearing the watcher down: an
EXITtrap did that, and the status the step ended with was whatever the trap left behind. It hit #424 and #425, both of which are comfortably above their floors.The fix
The ratchet's status is captured before anything is killed, and handed back explicitly. The child
sleepis killed and waited for, so the runner has no orphan to report either.The race is not reproducible on demand — which is a reason to remove the mechanism rather than to keep timing it.
Checked both ways, because a guard against a false failure must not swallow a real one:
🤖 Generated with Claude Code