Repository navigation
Import the landing kit as a Hugo module instead of a variant copy - #18
Merged
Merged
Conversation
The page carried its own styles.html with a ruby red written into the rules (#DC2626 -> #7F1D1D) that is not its logo's. It now imports github.com/go-fleettools/landingkit v0.2.0 (hugo.toml [module], go.mod, kit.go, setup-go before Hugo), and [params.brand] is generated by `landingkit brand static/img/logo.svg`: base #9b1c2e, deep #5f111c, bright #f0475a, the logo's own crimson. The nav bar's GitHub button, on the landing and on /performance/, gives way to the fork ribbon pointing at go-embedded-ruby/ruby. mark-github.html is the kit's icons/github.html. The variant sheet had no rule the kit lacks, so there is no site-styles.html. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Aligns the landing (and
/performance/) on go-fleettools/landingkit v0.2.0, the way go-fileshare.github.io#24 did for the reference.What changes
hugo.tomlimports the module;go.modpins v0.2.0;kit.go(//go:build tools) keeps Renovate'sgo mod tidyfrom deleting the requirement;actions/setup-goruns before Hugo indeploy-pages.yml.styles.html,theme-toggle.htmlandicons/mark-github.html(now the kit'sicons/github.html).icons/rocket.htmlandicons/graph.htmlstay as the site's own Octicons, withOCTICONS-LICENSE.[params.brand]is new, generated bylandingkit brand static/img/logo.svg: base#9b1c2e, deep#5f111c, bright#f0475a, the logo's own crimson. The variant sheet had a red written into its rules that is not the logo's:#DC2626 → #7F1D1D, dark accent#f2686d, plus the stats gradient#ffd9d9and band text#ffe1e1./performance/, the nav bar's GitHub button is replaced by the fork ribbon, pointing at go-embedded-ruby/ruby (where the button led).darkreader-lockcomes from the kit; the layouts had no duplicate..phero,.psec,table.bench, …) are already in the kit, so there is nosite-styles.html.Verification
landingkit verify go-embedded-ruby.github.io go-fileshare.github.io:.strip, which is 444px tall here, and its background is the kit's own--bg-soft(#f7f8fb/#111620). At those heights the reference page shows plain background.maingives the identical pixel result (same two samples, same colours). This is a limit of verify's fixed sample points, not a difference in the sheet.setViewport), light and dark, on/and/performance/: no horizontal scroll on main or on the branch. The theme toggle is hit-tested and clicked and changesdata-theme. The ribbon is hit-tested and clickable at every width.Visual differences, section by section (main vs branch, screenshots)
#DC2626 → #7F1D1Dto the logo's#9b1c2e → #5f111c, a darker, more crimson accent. This shows in the "written in Go." accent, the "Get started" button and the washes. In dark mode the accent goes from#f2686dto#f0475a.#ffe1e1to the kit's#d8f3fb.#cdf1fainstead of#ffd9d9.Checks
No check changes:
deploy-pages(build).🤖 Generated with Claude Code