Speed up scope parsing, especially for deep scopes - #1428
Open
sirosen wants to merge 3 commits into
Open
Conversation
sirosen
requested review from
MaxTueckeGlobus,
aaschaer,
ada-globus,
derek-globus,
kurtmckee and
m1yag1
as code owners
September 8, 2026 16:58
Merging this PR will improve performance by ×3.9
Performance Changes
Tip Curious why performance improved? Comment Comparing |
The graph intermediate representation tracked a set of nodes which is never read. Removing it is a minor micro-optimization.
`reversed()` produces an iterator, rather than a brand new list, so it's more lightweight. (This is a micro-optimization.)
sirosen
force-pushed
the
faster-scope-parsing
branch
from
September 8, 2026 18:49
b34723a to
609c52b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There are three distinct optimizations here, applied in series:
By way of explanation, the first optimization, which does some graph-coloring with an enum to search for back-edges.
This replaces the prior implementation, which made sets of "all ancestors" for each node, which results in a large number of new sets being built, especially for deeper scopes.
The micro-optimizations are very minor cleanup (the commits should be self-explanatory).