feat(glean)!: rename glean_run skill to glean-run - #29
Open
steve-calvert-glean wants to merge 1 commit into
Open
steve-calvert-glean wants to merge 1 commit into
steve-calvert-glean wants to merge 1 commit into
Conversation
Agent Skills names allow only lowercase letters, digits, and hyphens, and must match their directory. Clients that follow the Agent Plugins spec skip a skill that breaks the rule, so glean_run would silently disappear once Codex output moves to the Agent Plugins layout (pluginpack 0.12). Renames the shared skill's directory and frontmatter name, and updates its entry in the MCP shipping-file map. Claude Code, Cursor, and Codex all accept the new name on pluginpack 0.11. BREAKING CHANGE: the skill is now invoked as /glean-run (Cursor, Claude Code) instead of /glean_run.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Important
Hold the release after merging. Merging is safe, but the next release publishes the new name to the plugin repos. Before cutting it:
python_scio/scripts/tests/yoda_playwright_automation/component_tests/glean_run_plugin) acceptglean-run. Every Codex test currently asserts thatglean_run/SKILL.mdwas read.askscio/glean-docs): the plug-in user guide says to invoke/glean_runin its setup, verification, and usage sections. Check the other plug-in pages (Cursor, Claude Code, Codex setup, troubleshooting) too.The commit is
feat(glean)!, so release-it will propose 4.0.0.Why this rename is needed
In short:
glean_runisn't a valid skill name under the open Agent Skills standard. Codex and ChatGPT are moving to a plugin format whose clients must drop invalid skills. Without the rename, Codex users would lose the plugin's main skill, possibly with no error.glean_runbreaks it. The Agent Skills spec says a skill name "may only contain unicode lowercase alphanumeric characters (a-z, 0-9) and hyphens (-)" and "must match the parent directory name." The underscore makesglean_runinvalid.glean_runwould be missing, possibly with no error..codex-plugin/plugin.jsononly "as a compatibility fallback." pluginpack 0.12 (feat!: emit Agent Plugins packages from codex and add an agent-plugins target pluginpack#38) switches our Codex output to it, and VS Code/Copilot load the same format. pluginpack 0.12 also failsnpm run validateon the old name, so we find out at build time, not from users./glean_runwhen they want Glean to discover a skill or tool. It's the plug-in's entry point, not an optional extra.Why rename it everywhere instead of only for Codex: one command name across Cursor, Claude Code, and Codex keeps docs and support simple. The hyphenated name already works on all three today. A Codex-only rename would leave
/glean-runin one client and/glean_runin the others.Why not stay on the legacy Codex layout: that only delays the rename. OpenAI supports the legacy layout as a fallback, not as the direction forward.
What
shared/glean/mcp/skills/glean_run/→glean-run/, with frontmattername: glean-run.mcp/pluginpack.jsonshipping-file entry and one comment instart.mjs.No other source in this repo references the old name. This PR works on the current pluginpack (0.11) and doesn't need 0.12.
Verification
npm test(build + validate for claude, cursor, codex) passes; all three targets shipskills/glean-run/SKILL.md.check:no-shell,check:release-version,typecheck:bundle, andtest:bundle(432 tests) pass.overrides/codex/glean/mcp/config.jsondeleted, all three targets validate, and Codex gets a valid Agent Pluginsplugin.json+mcp.json.Follow-up
After pluginpack 0.12 is released: bump
@gleanwork/pluginpack, deleteoverrides/codex/glean/mcp/config.json(0.12 renders the shared MCP config for Codex), and regenerate.