fix: skip write approval when HITL is off or permissions bypassed - #28
Merged
pragati-agrawal-glean merged 2 commits intoSep 28, 2026
Merged
pragati-agrawal-glean merged 2 commits into
pragati-agrawal-glean merged 2 commits into
Conversation
Use request-local Claude hook context for bypass mode and keep run_tool approval in the local plugin. Disable approval lookup and upstream forms when opted out, without saving an Always Allow preference. — sent via Glean Tau
Remove the session-context protocol and broad test harness. Reuse the existing permission-mode lookup to skip local and upstream approval when HITL is off or the reported mode is bypassPermissions. — sent via Glean Tau
pragati-agrawal-glean
changed the title
pragati-agrawal-glean
marked this pull request as ready for review
September 28, 2026 15:19
pragati-agrawal-glean
requested review from
eshwar-sundar-glean,
mohit-gupta-glean and
nikhil-pitta-glean
September 28, 2026 15:19
garvit-scio
approved these changes
Sep 28, 2026
garvit-scio
left a comment
garvit-scio
left a comment
There was a problem hiding this comment.
patched my local cached pluin copy with this. confirming it works
pragati-agrawal-glean
deleted the
pragati/agent-plugins-hitl-policy/fix-session-approval
branch
September 28, 2026 16:14
Contributor
|
Make sure to check why this happened |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
bypassPermissions, execute without approval lookup, elicitation, or preference writes.Testing
npm run typecheck:bundle;npm run test:bundle— 432 tests passed.npm test— build and validation passed for Claude, Cursor, and Codex.run_tool, with no approval lookup, prompt, or preference write.— sent via Glean Tau