Skip to content

fix(mst2): place chunk-map SQL tests after production items #80

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Ivanbeethoven merged 1 commit into from
Oct 7, 2026
Merged

fix(mst2): place chunk-map SQL tests after production items #80

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
55 changes: 28 additions & 27 deletions src/jupiter/storage/native_chunk_map.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -605,33 +605,6 @@ fn qualify_relations(schema: &str, sql: &str) -> String {
qualified
}

#[cfg(test)]
mod sql_tests {
use super::*;

#[test]
fn authority_relations_are_qualified_without_rewriting_catalog_literals() {
let sql = "SELECT 'mst2_metadata_storage_scope','quoted ''mst2_chunk_map''',\"mst2_chunk_map\" FROM mst2_metadata_storage_scope s JOIN mst2_verified_object f ON s.singleton=1 JOIN mst2_chunk_map m ON true JOIN mst2_chunk_map_leaf l ON true JOIN mst2_chunk_map_node n ON true JOIN mst2_chunk_map_source r ON true WHERE c.relname='mst2_metadata_storage_scope'";
let qualified = qualify_relations("schema\"name", sql);
assert!(qualified.contains(&format!(
"FROM {}.mst2_metadata_storage_scope",
quoted("schema\"name")
)));
for name in [
"mst2_verified_object",
"mst2_chunk_map",
"mst2_chunk_map_leaf",
"mst2_chunk_map_node",
"mst2_chunk_map_source",
] {
assert!(qualified.contains(&format!("JOIN {}.{name}", quoted("schema\"name"))));
}
assert!(qualified.starts_with(
"SELECT 'mst2_metadata_storage_scope','quoted ''mst2_chunk_map''',\"mst2_chunk_map\""
));
assert!(qualified.ends_with("WHERE c.relname='mst2_metadata_storage_scope'"));
}
}
fn bounded_bytes(row: &QueryResult, name: &str) -> Result<Vec<u8>, SnapshotError> {
row.try_get::<Option<Vec<u8>>>("", name)
.map_err(db_error)?
Expand Down Expand Up @@ -682,3 +655,31 @@ impl super::Storage {
.await
}
}

#[cfg(test)]
mod sql_tests {
use super::*;

#[test]
fn authority_relations_are_qualified_without_rewriting_catalog_literals() {
let sql = "SELECT 'mst2_metadata_storage_scope','quoted ''mst2_chunk_map''',\"mst2_chunk_map\" FROM mst2_metadata_storage_scope s JOIN mst2_verified_object f ON s.singleton=1 JOIN mst2_chunk_map m ON true JOIN mst2_chunk_map_leaf l ON true JOIN mst2_chunk_map_node n ON true JOIN mst2_chunk_map_source r ON true WHERE c.relname='mst2_metadata_storage_scope'";
let qualified = qualify_relations("schema\"name", sql);
assert!(qualified.contains(&format!(
"FROM {}.mst2_metadata_storage_scope",
quoted("schema\"name")
)));
for name in [
"mst2_verified_object",
"mst2_chunk_map",
"mst2_chunk_map_leaf",
"mst2_chunk_map_node",
"mst2_chunk_map_source",
] {
assert!(qualified.contains(&format!("JOIN {}.{name}", quoted("schema\"name"))));
}
assert!(qualified.starts_with(
"SELECT 'mst2_metadata_storage_scope','quoted ''mst2_chunk_map''',\"mst2_chunk_map\""
));
assert!(qualified.ends_with("WHERE c.relname='mst2_metadata_storage_scope'"));
}
}
Loading