bump git-internal to 0.8.5 - #2161
Conversation
Merge runner and client rows into one table with This env / Other / All filters, truncate overflowing cells with tooltips, and restore start time plus heartbeat columns.
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 2598433746
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| for (const client of clients) { | ||
| const domain = domainFromClientHostname(client.hostname) | ||
|
|
||
| if (domain && usedDomains.has(domain)) continue |
There was a problem hiding this comment.
When a runner exists for a domain, this continue suppresses every client whose hostname parses to that domain; clientByDomain only kept the most recent one for attaching to the runner. The Orion clients endpoint is keyed by client_id and can have several workers with the same hostname (the server URL), so as soon as a runner is present the rest of those clients disappear from the table and their log/terminal actions are unreachable. Keep unmatched clients as separate rows, or mark only the attached client as used, instead of dropping by domain.
Useful? React with 👍 / 👎.
2 participants
No description provided.