Repository navigation
chore(renovate): track the smoke-test Dockerfile image - #36
Merged
Merged
Conversation
setchy
force-pushed
the
chore/renovate-manage-test-dockerfile
branch
from
October 8, 2026 14:17
5bdbbc0 to
1aedba2
Compare
setchy
marked this pull request as ready for review
October 8, 2026 14:27
setchy
force-pushed
the
chore/renovate-manage-test-dockerfile
branch
from
October 8, 2026 14:28
1aedba2 to
6e1fc97
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Why
Renovate currently skips
tests/shell/Dockerfile, so theubuntu:26.04@sha256:…base image is never kept up to date. The repo inheritsconfig:best-practices, which includes:ignoreModulesAndTests— its globalignorePathscontains**/tests/**, which excludes this Dockerfile during extraction. That is why the Dependency Dashboard (#2) has nodockerfilesection.Change
renovate.json: give thedockerfilemanager its ownignorePaths, scoped to that manager, omitting**/tests/**. Adescriptionon the manager records the why inline, since JSON has no comments.Why scoped to the
dockerfilemanagerincludePathscan't be used here:ignorePathstakes precedence, sodockerfile.includePaths: ["tests/shell/Dockerfile"]still leaves the file ignored (verified locally).packageRules/matchFileNamesrule can't help either: ignore filtering happens during extraction, before package rules run.ignorePathswould work but is broader than needed — it would re-includetests/for every manager (npm, etc.). Scoping it todockerfilere-includestests/for that manager only, while the global**/tests/**ignore stays in place for everything else.Renovate keeps the version tag alongside the digest and updates both together (default
docker:pinDigestsbehaviour), e.g.ARG GNOME_TEST_IMAGE=ubuntu:26.04@sha256:…. Theapt-get installpackages are unversioned and skipped (unspecified-version), so no extra PRs are expected.Validation
renovate-config-validator— config validdockerfilemanager now extractstests/shell/Dockerfile(ubuntu,currentValue: 26.04,currentDigest: sha256:cd21…) and generates the tag+digest replacement templatetests/(atests/fixture/package.jsonis not picked up)