Skip to content

chore(renovate): track the smoke-test Dockerfile image - #36

Merged
setchy merged 1 commit into
mainfrom
chore/renovate-manage-test-dockerfile
Oct 8, 2026
Merged

setchy merged 1 commit into
mainfrom
chore/renovate-manage-test-dockerfile

Conversation

@setchy

@setchy setchy commented Oct 8, 2026 •

Copy link
Copy Markdown
Member

Why

Renovate currently skips tests/shell/Dockerfile, so the ubuntu:26.04@sha256:… base image is never kept up to date. The repo inherits config:best-practices, which includes :ignoreModulesAndTests — its global ignorePaths contains **/tests/**, which excludes this Dockerfile during extraction. That is why the Dependency Dashboard (#2) has no dockerfile section.

Change

  • renovate.json: give the dockerfile manager its own ignorePaths, scoped to that manager, omitting **/tests/**. A description on the manager records the why inline, since JSON has no comments.

Why scoped to the dockerfile manager

  • includePaths can't be used here: ignorePaths takes precedence, so dockerfile.includePaths: ["tests/shell/Dockerfile"] still leaves the file ignored (verified locally).
  • An explicit packageRules/matchFileNames rule can't help either: ignore filtering happens during extraction, before package rules run.
  • Redefining the global ignorePaths would work but is broader than needed — it would re-include tests/ for every manager (npm, etc.). Scoping it to dockerfile re-includes tests/ for that manager only, while the global **/tests/** ignore stays in place for everything else.

Renovate keeps the version tag alongside the digest and updates both together (default docker:pinDigests behaviour), e.g. ARG GNOME_TEST_IMAGE=ubuntu:26.04@sha256:…. The apt-get install packages are unversioned and skipped (unspecified-version), so no extra PRs are expected.

Validation

  • renovate-config-validator — config valid
  • Local extraction: the dockerfile manager now extracts tests/shell/Dockerfile (ubuntu, currentValue: 26.04, currentDigest: sha256:cd21…) and generates the tag+digest replacement template
  • Local extraction: other managers still ignore tests/ (a tests/fixture/package.json is not picked up)

@setchy
setchy force-pushed the chore/renovate-manage-test-dockerfile branch from 5bdbbc0 to 1aedba2 Compare October 8, 2026 14:17
@setchy
setchy marked this pull request as ready for review October 8, 2026 14:27
@setchy
setchy requested a review from afonsojramos as a code owner October 8, 2026 14:27
@setchy
setchy force-pushed the chore/renovate-manage-test-dockerfile branch from 1aedba2 to 6e1fc97 Compare October 8, 2026 14:28
@sonarqubecloud

sonarqubecloud Bot commented Oct 8, 2026

Copy link
Copy Markdown

@setchy
setchy merged commit 235eea9 into main Oct 8, 2026
8 checks passed
@setchy
setchy deleted the chore/renovate-manage-test-dockerfile branch October 8, 2026 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant