Repository navigation
Conversation
Enable lint.options.typeAware/typeCheck so `vp check` runs format, lint, and TypeScript type checks natively, then drop the separate `tsc --noEmit` step from the test workflow. Type checking now happens once, in the `lint` job that `tests` already depends on. Drive the type-aware findings to zero: - scope `typescript/unbound-method` off for test doubles, which are typed as the real Electron/interface classes - add `void`/remove redundant `await` for floating promises and non-thenable awaits; normalise `HeadersInit` merging via mergeHeaders - declare the previously transitive `graphql-config` devDependency
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Summary
Switches type checking to Vite+'s native path and drives all resulting type-aware findings to zero.
lint.options.typeAware/typeChecksovp checkruns format, lint, and TypeScript type checks in one command.pnpm checknow matches CI, closing the local/CI gap.vp exec tsc --noEmitstep fromtest.yml:lint.ymlalready runsvp run check, andtestsdepends onlintin bothci.ymlandrelease.yml, so type-checking runs exactly once with no gap.ci.yml.Supersedes #3417, which added
vp check && vp exec tsc --noEmit. Native checking is equivalent and avoids the redundanttscrun.Findings fixed
Enabling
typeAwarealso turns on the type-aware lint rules; all 182 findings are resolved:unbound-methodon test doubles (100) — scoped off for**/*.test.*,__mocks__/__helpers__; the mocks are typed as the real Electron/interface classes.unbound-methodin source (18) —logger.ts,registry.ts,notifications.ts,tailwind.config.mts.no-floating-promises(25),await-thenable(22) —void/ removed redundant awaits.no-misused-spread(11) — new sharedmergeHeadershelper; plain-object test events.no-base-to-string(3), plusLogoIcon.sizemade optional, theIpcHandlertype, andgraphql-configdeclared as a direct devDependency.Notes for review
await expect.element(...)calls carry an inlinetypescript/await-thenabledisable: Vitest types the matcher return asHTMLElement | nullwhile the runtime returns a poll promise, so theawaitis required for retry semantics.tsc(it also checks root config files such asgraphql.config.tsandtailwind.config.mts), which is how the missinggraphql-configsurfaced.Verification
pnpm check— pass (format + lint + type check, 441 files)pnpm test— 1901 tests passing