Skip to content

Stabilize comment geometry recovery test #142

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MaggieAppleton merged 1 commit into from
Aug 28, 2026
Merged

Stabilize comment geometry recovery test #142

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 13 additions & 1 deletion e2e/sidecar.e2e.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -828,7 +828,19 @@ test("an unavailable comment position keeps its compact sheet mounted until geom
viewport: { width: 390, height: 300 },
});
let editor = content(page);
await editor.locator("p").first().selectText();
await editor.locator("p").first().evaluate(paragraph => {
let phrase = "A selected passage keeps going.";
let text = paragraph.querySelector("[data-lexical-text]")?.firstChild;
if (!(text instanceof Text) || !text.data.startsWith(phrase)) {
throw new Error("expected the tall passage fixture");
}
let range = document.createRange();
range.setStart(text, 0);
range.setEnd(text, phrase.length);
let selection = getSelection();
selection?.removeAllRanges();
selection?.addRange(range);
});
await page.getByRole("button", { name: "Comment on this passage", exact: true }).click();
let draft = page.getByRole("dialog", { name: "New comment" });
await draft.getByPlaceholder("Comment on this passage…").fill("Keep the whole passage.");
Expand Down
Loading