Skip to content

refactor(ado-proxy): reduce complexity of operations() in catalog.rs #2081

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
github-actions wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

refactor(ado-proxy): reduce complexity of operations() in catalog.rs #2081

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
38 changes: 38 additions & 0 deletions src/ado_proxy/catalog.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -249,6 +249,17 @@ pub fn catalog() -> Catalog {
}

pub fn operations() -> Vec<Operation> {
let mut ops = discovery_operations();
ops.extend(core_operations());
ops.extend(repos_operations());
ops.extend(pipelines_operations());
ops.extend(boards_operations());
ops
}

/// Discovery-capability operations: organization/area/resource-area
/// bootstrap probes issued before any data call.
fn discovery_operations() -> Vec<Operation> {
vec![
Operation {
id: "discovery.host-options",
Expand Down Expand Up @@ -325,6 +336,12 @@ pub fn operations() -> Vec<Operation> {
Json,
&["connectOptions", "lastChangeId", "lastChangeId64"]
),
]
}

/// Core-capability operations: project metadata lookups.
fn core_operations() -> Vec<Operation> {
vec![
get!(
"core.project-get",
Core,
Expand Down Expand Up @@ -352,6 +369,13 @@ pub fn operations() -> Vec<Operation> {
"getDefaultTeamImageUrl",
]
),
]
}

/// Repos-capability operations: git repository, ref, item, commit, and
/// pull-request read paths.
fn repos_operations() -> Vec<Operation> {
vec![
get!(
"repos.repository-get",
Repos,
Expand Down Expand Up @@ -498,6 +522,13 @@ pub fn operations() -> Vec<Operation> {
Json,
NO_QUERY
),
]
}

/// Pipelines-capability operations: build definition, build, timeline, and
/// pipeline run read paths.
fn pipelines_operations() -> Vec<Operation> {
vec![
get!(
"pipelines.definitions-list",
Pipelines,
Expand Down Expand Up @@ -601,6 +632,13 @@ pub fn operations() -> Vec<Operation> {
Json,
NO_QUERY
),
]
}

/// Boards-capability operations: work-item, comment, update, and revision
/// read paths.
fn boards_operations() -> Vec<Operation> {
vec![
get!(
"boards.work-item-get",
Boards,
Expand Down